More general organisation and fixes

[GregHib]

• Add smelting tests Add missing tests for skills #583
• Add jewellery crafting tests Add missing tests for skills #583
• Move agility tests
• Extract SpellRunes from Spell
• Extract Light from GiantMole
• Add command search to "find" command
• Fix coal bag
• Add tab changing method
• Rename quest methods
• Rename all Hit's to Defend, Damage or Impact
• Make Item's default amount 1
• Rename pickup to take
• Remove overrides from FloorItemOption Simplified event handling #582
• Fix empty statement dialogues
• Fix varrock manhole ladder
• Fix suspendable dialogues

[github-actions]

Qodana Community for JVM

1 new problem were found

Inspection name	Severity	Problems
Unused symbol	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[codecov]

Codecov Report

Attention: Patch coverage is 48.17814% with 256 lines in your changes missing coverage. Please review.

Project coverage is 35.07%. Comparing base (9257c97) to head (00e94bd).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tent/entity/player/command/debug/DebugCommands.kts	0.00%	18 Missing ⚠️
...voidps/engine/entity/item/floor/FloorItemOption.kt	0.00%	14 Missing ⚠️
.../main/kotlin/content/skill/prayer/active/Leech.kts	20.00%	8 Missing and 4 partials ⚠️
...tent/entity/player/command/admin/AdminCommands.kts	0.00%	11 Missing ⚠️
...ain/kotlin/content/skill/magic/spell/SpellRunes.kt	92.85%	1 Missing and 9 partials ⚠️
...ntent/area/misthalin/lumbridge/LumbridgeChurch.kts	0.00%	8 Missing ⚠️
.../kotlin/content/area/misthalin/varrock/Delrith.kts	0.00%	8 Missing ⚠️
game/src/main/kotlin/content/skill/melee/Block.kts	38.46%	4 Missing and 4 partials ⚠️
.../gregs/voidps/engine/suspend/SuspendableContext.kt	12.50%	7 Missing ⚠️
...content/skill/melee/weapon/special/KorasiSword.kts	0.00%	7 Missing ⚠️
... and 74 more

Additional details and impacted files

Files with missing lines	Coverage Δ
...tlin/world/gregs/voidps/engine/entity/item/Item.kt	56.52% <100.00%> (ø)
.../world/gregs/voidps/engine/queue/ActionPriority.kt	100.00% <ø> (ø)
...kotlin/content/area/asgarnia/port_sarim/Thurgo.kts	3.96% <100.00%> (ø)
...n/kotlin/content/area/asgarnia/taverley/Sanfew.kts	7.05% <100.00%> (ø)
...andarin/barbarian_outpost/BarbarianOutpostGate.kts	60.00% <100.00%> (ø)
...n/content/area/wilderness/abyss/AbyssObstacles.kts	97.26% <100.00%> (ø)
...n/kotlin/content/entity/combat/hit/CombatAttack.kt	92.85% <ø> (ø)
...n/kotlin/content/entity/combat/hit/CombatDamage.kt	92.59% <100.00%> (ø)
...e/src/main/kotlin/content/entity/combat/hit/Hit.kt	66.66% <100.00%> (ø)
...c/main/kotlin/content/entity/death/PlayerDeath.kts	54.36% <100.00%> (ø)
... and 95 more

... and 6 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #604      +/-   ##
============================================
+ Coverage     34.90%   35.07%   +0.17%     
- Complexity     4889     4922      +33     
============================================
  Files          1339     1343       +4     
  Lines         47120    47181      +61     
  Branches       9502     9506       +4     
============================================
+ Hits          16445    16549     +104     
+ Misses        27294    27231      -63     
- Partials       3381     3401      +20     

Components	Coverage Δ
Content	28.94% <50.75%> (+0.33%)	⬆️
Engine	43.45% <6.89%> (-0.05%)	⬇️
Network	71.85% <ø> (ø)