Update oxipng to v9 [updated] #1396
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
andrews05
force-pushed
the
oxipng9
branch
2 times, most recently
from
56d42b6 to
a38577d
Compare
|
Fixed the parallel build by updating wasm-pack. It's all working now! |
|
Another update: I've reworked it to use the raw api, so it doesn't need to convert to png first. |
|
@surma this looks could. Could you give the rust bits a review? |
|
|
||
| options.deflate = oxipng::Deflaters::Libdeflater; |
There was a problem hiding this comment.
Oh I just saw that Oxipng now also offers Zopfli. Coo. We should expose that at some point.
There was a problem hiding this comment.
We absolutely should
|
The demo Squoosh logo, with 256 colors, no dithering, goes from 17.7kb to 17.2kb with this change. Nice. |
|
Awesome, thanks guys! |
|
Deployed! Thanks for the contribution. Excellent improvement. |
I've attempted to update to oxipng to v9, but the parallel build doesn't seem to work - the worker seems to hang when encoding. When I changed the encoder to always
initST()it all worked fine.Not sure how to debug it from here. I've spent hours just getting the thing to build correctly 😩. (Not currently possible on Apple Silicon, it seems).
There's also the new raw API in v9 which may be of use here, but I'll probably leave that for someone else 😆