Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor inconsistencies adjustments #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor inconsistencies adjustments #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccb1cb5
Update isc2018-1.ttl
alexandretessarollo Dec 1, 2019
e8955a3
Update isc2018-1.ttl
alexandretessarollo Dec 1, 2019
f87ba1c
Update isc2018-1.ttl
alexandretessarollo Dec 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions resource/static/vocabulary/timescale/isc2018-1.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,6 @@ isc:Asselian
time:intervalMetBy isc:Carboniferous ;
time:intervalMetBy isc:Gzhelian ;
time:intervalMetBy isc:Pennsylvanian ;
time:intervalMetBy isc:UpperMississippian ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

time:intervalMetBy isc:UpperPennsylvanian ;
time:intervalStarts isc:Cisuralian ;
foaf:primaryTopicOf <http://sweetontology.net/stateTimeGeologic/Asselian> ;
Expand Down Expand Up @@ -5809,8 +5808,7 @@ isc:Capitanian
skos:prefLabel "卡匹敦期"@zh ;
time:hasBeginning isc:BaseCapitanian ;
time:hasEnd isc:BaseLopingian ;
time:intervalDuring isc:Guadalupian ;
time:intervalIn isc:Guadalupian ;
time:intervalFinishes isc:Guadalupian ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Good catch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time:intervalIn axiom is not incorrect, but is redundant with the time:intervalFinishes axiom

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time:intervalIn axiom is not incorrect, but is redundant with the time:intervalFinishes axiom

That is why I suggested it’s removal. Don’t you agree it should be removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to remove it. It does not introduce any inconsistencies.

time:intervalMeets isc:Lopingian ;
time:intervalMeets isc:Wuchiapingian ;
time:intervalMetBy isc:Wordian ;
Expand Down Expand Up @@ -11707,7 +11705,6 @@ isc:Roadian
time:hasEnd isc:BaseWordian ;
time:intervalIn isc:Guadalupian ;
time:intervalMeets isc:Wordian ;
time:intervalMetBy isc:Capitanian ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

time:intervalMetBy isc:Cisuralian ;
time:intervalMetBy isc:Kungurian ;
time:intervalStarts isc:Guadalupian ;
Expand Down