Minor inconsistencies adjustments #6
Conversation
Deleted line 11710: Age Roadian ˜is time:intervalMetBy isc:Capitanian˜ Roadian actually takes place before Age Capitanian
Lines 5812 and 5813 said Capitanian ˜time:intervalduring isc:Guadalupian" and "time:intervalIn isc:Guadalupian˜. Despite being correct, they were replaced with ˜intervalFinishes˜, which encompass the information in those previous lines and adds the information that Guadalupian and Capitanian have the same ending and that Guadalupian starts before Capitanian.
Removed line 580: Asselian "time:intervalMetBy isc:UpperMississippian" This information is incorrect
| @@ -11707,7 +11707,6 @@ isc:Roadian | |||
| time:hasEnd isc:BaseWordian ; | |||
| time:intervalIn isc:Guadalupian ; | |||
| time:intervalMeets isc:Wordian ; | |||
| time:intervalMetBy isc:Capitanian ; | |||
| @@ -5809,8 +5809,7 @@ isc:Capitanian | |||
| skos:prefLabel "卡匹敦期"@zh ; | |||
| time:hasBeginning isc:BaseCapitanian ; | |||
| time:hasEnd isc:BaseLopingian ; | |||
| time:intervalDuring isc:Guadalupian ; | |||
| time:intervalIn isc:Guadalupian ; | |||
| time:intervalFinishes isc:Guadalupian ; | |||
There was a problem hiding this comment.
The time:intervalIn axiom is not incorrect, but is redundant with the time:intervalFinishes axiom
There was a problem hiding this comment.
The
time:intervalInaxiom is not incorrect, but is redundant with thetime:intervalFinishesaxiom
That is why I suggested it’s removal. Don’t you agree it should be removed?
There was a problem hiding this comment.
There is no need to remove it. It does not introduce any inconsistencies.
| @@ -577,7 +577,6 @@ isc:Asselian | |||
| time:intervalMetBy isc:Carboniferous ; | |||
| time:intervalMetBy isc:Gzhelian ; | |||
| time:intervalMetBy isc:Pennsylvanian ; | |||
| time:intervalMetBy isc:UpperMississippian ; | |||
|
Fixed in forked subtree dr-shorthair/timescale-data@9aa12b0#diff-0362b2f2cc2144f2ec43079263616c6e |
|
confusing. You are mentioning the https://github.com/dr-shorthair/timescale-data but this repo is archieved. If I understood it right, the new repo is actually https://github.com/CGI-IUGS/timescale-data. Right? |
|
The question is if this PR should be closed and a new PR submitted to the new repo or if during the creation of the new repo the changes proposed here were already considered. |
|
Correct - /dr-shorthair/ repo was an interim location while I sorted out push permission at /CGI-IUGS/ |
|
The changes proposed here were all implemented in the fork. |
|
the updates have been made in https://github.com/CGI-IUGS/timescale-data/blob/master/rdf/isc2019.ttl. what fork are you referring to @dr-shorthair ? |
Removed two lines with wrong definitions and replaced other two by one