-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic LinkML linting of schema on each PR changing schema #896
Add automatic LinkML linting of schema on each PR changing schema #896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR up into the main
branch of the original repo @jfy133.
I've noted a couple of review comments on your PR, we can work on fixing some of these up and we'll try to merge this PR in, in the coming days.
I hope you don't mind @jfy133 but I changed the base branch of this PR to another branch called |
All but one comments addressed @sujaypatil96 ! Feel free to make direct suggestions when commenting (then I can just press commit, rather than having to copy paste) - or even push directly (I'm not precious about this). Sounds good to moving to an internal testing branch first! |
Should be ready to go @sujaypatil96 |
It's not useful to have a linkml linter config file that simply extends the recommended set of linting rules, it does that by default. Linter config files are useful only if we're deviating from the default (custom), so I think it's okay to delete that file altogether. After that we should be good for approval and merge. |
…nto automated-linkml-linting
I've gone ahead and made that change. Once the Actions go through, I'll approve and merge this PR in. Then we can open a PR from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this PR @jfy133! approving and merging it in 🚀
a13f8fe
into
GenomicsStandardsConsortium:automated-linkml-linting
Nice! Thanks @sujaypatil96 look forward to the new PR 🤞🤞🤞🤞 |
This adds a github action that runs the LinkML linting if the schema changes, and posts a nicely formatted comment listing all the issues.
Note it currently configures the linting to ignore warnings related to 'standard naming'.