Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN 2.10 + Cypress 12.10.0 #162

Merged
merged 43 commits into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
45d48c0
new: default to test with CKAN 2.10
nickumia-reisys Apr 18, 2023
5a181f5
update: spatial to ckan 2.10 compatible version
nickumia-reisys Apr 18, 2023
61d0ea3
pin: solr/db docker don't have ckan 2.10 versions
nickumia-reisys Apr 18, 2023
090f7ff
new: remove future + reorg import references
nickumia-reisys Apr 18, 2023
9b96d8c
cleanup: remove deprecated IRoutes
nickumia-reisys Apr 18, 2023
dadba59
update: url --> url_for
nickumia-reisys Apr 18, 2023
eea3785
update: flash.pop_messages deprecated
nickumia-reisys Apr 18, 2023
a31fe80
update: build_nav_icon
nickumia-reisys Apr 18, 2023
a5f0503
update: test dataset id is not guaranteed in CKAN 2.10
nickumia-reisys Apr 19, 2023
c38f01f
cleanup: new_activities does not exist in CKAN 2.10
nickumia-reisys Apr 19, 2023
f94cab7
update: setup.py version
nickumia-reisys Apr 19, 2023
6a48004
fix: seed.py, make a new sysadmin
nickumia-reisys Apr 19, 2023
8b031c6
NEW: migrate to cypress 12
nickumia-reisys Apr 19, 2023
63f4cf1
fix: ckan messed with our styles...
nickumia-reisys May 22, 2023
7727e83
new: track upstream search_form.html template
nickumia-reisys May 24, 2023
fc736a9
new: add customization to keep old feel
nickumia-reisys May 24, 2023
6dee409
refactor: remove indentation
nickumia-reisys May 24, 2023
30dbeff
fix order-by and magifying glass style
FuhuXia May 26, 2023
b5a96b3
fix the icon display problem for home, twitter and github
Jin-Sun-tts Jun 2, 2023
590974e
remove cypress test videos
Jin-Sun-tts Jun 2, 2023
b1c07a4
fix couple of UI issues
Jin-Sun-tts Jun 6, 2023
c7dd96e
remove temp files
Jin-Sun-tts Jun 6, 2023
d1bb46b
fix UI issues including line space, harvest page etc
Jin-Sun-tts Jun 7, 2023
49a6c92
fix facet issue in orgnazition page and the bulk process dataset list…
Jin-Sun-tts Jun 8, 2023
360433a
added label style for 'error' in harvester jobs page
Jin-Sun-tts Jun 9, 2023
bd92dd3
fix missing icon issues for calendar, license, edit and organization
Jin-Sun-tts Jun 13, 2023
9bea249
remove p-2, masthead padding
Jin-Sun-tts Jun 13, 2023
db37227
fix the icon and label for 'collaction'
Jin-Sun-tts Jun 13, 2023
e8d5961
remove inline style
FuhuXia Jun 13, 2023
20bbeaa
Merge pull request #165 from GSA/remove-inline-style
btylerburton Jun 15, 2023
0ec706c
Merge branch 'main' into ckan-210
FuhuXia Jun 16, 2023
76967b4
change the category and class name for flash messages
Jin-Sun-tts Jun 28, 2023
aa1a621
fix issue for collection resource section
Jin-Sun-tts Jun 28, 2023
7af1a08
fix/cleanup: custom resource link updating
nickumia-reisys Jun 28, 2023
7ec4c0b
revert: data_preview block, only delete the custom function call
nickumia-reisys Jun 28, 2023
4769814
new/fix: add geodatagov as dependency
nickumia-reisys Jun 30, 2023
81de65e
remove new+index
FuhuXia Jul 10, 2023
250a8ff
update: setup.py version
nickumia-reisys Jul 11, 2023
eb31058
docs: update compatibility
nickumia-reisys Jul 11, 2023
dbfeb1c
changed the font color of 'errors' label to white, and disabled the h…
Jin-Sun-tts Jul 18, 2023
5806446
Merge pull request #168 from GSA/fix-harvest-job-label
FuhuXia Jul 18, 2023
41f746f
fix dependency
FuhuXia Jul 18, 2023
5efb291
remove the duplication of data-diff=error
Jin-Sun-tts Jul 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
uses: gsa/data.gov/.github/workflows/ckan-test.yml@main
with:
ext_name: datagovtheme
plugins: harvest datagovtheme
plugins: harvest datagovtheme geodatagov
secrets: inherit

ui-test:
Expand Down
8 changes: 4 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ syntax: glob
.vscode/

# Cypress
e2e/cypress/videos/*
e2e/cypress/screenshots/*
e2e/cypress/results/output.xml
cypress/e2e/videos/*
cypress/e2e/screenshots/*
cypress/e2e/results/output.xml
node_modules
package-lock.json
package-lock.json
7 changes: 3 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
ARG CKAN_VERSION=2.9
ARG CKAN_VERSION=2.10.1
FROM openknowledge/ckan-dev:${CKAN_VERSION}
ARG CKAN_VERSION

# Add timezone data if it does not exist
RUN if [[ "${CKAN_VERSION}" = "2.9" ]]; then sudo apk add tzdata; fi
# Add timezone data
RUN sudo apk add tzdata

COPY . $APP_DIR/
# WORKDIR /app

RUN pip install -r $APP_DIR/requirements.txt -r $APP_DIR/dev-requirements.txt -e $APP_DIR/.
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CKAN_VERSION ?= 2.9
CKAN_VERSION ?= 2.10
btylerburton marked this conversation as resolved.
Show resolved Hide resolved
COMPOSE_FILE ?= docker-compose.yml

build: ## Build the docker containers
Expand All @@ -17,6 +17,9 @@ test: ## Run extension tests
ui-test:
CKAN_VERSION=$(CKAN_VERSION) docker-compose -f $(COMPOSE_FILE) -f docker-compose.test.yml up --abort-on-container-exit test

ui-interactive:
CYPRESS_BASE_URL=http://ckan:5000 npx cypress open

up: ## Start the containers
CKAN_VERSION=$(CKAN_VERSION) docker-compose -f $(COMPOSE_FILE) up

Expand Down
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ This extension is compatible with these versions of CKAN.
CKAN version | Compatibility
------------ | -------------
<=2.8 | no
2.9 | yes
2.9 | 0.1.27 (last supported)
2.10 | >=0.2.0


### Configuration
Expand Down Expand Up @@ -115,10 +116,10 @@ In order to support multiple versions of CKAN, or even upgrade to new versions
of CKAN, we support development and testing through the `CKAN_VERSION`
environment variable.

$ make CKAN_VERSION=2.9 test
$ make CKAN_VERSION=2.10 test


Variable | Description | Default
-------- | ----------- | -------
CKAN_VERSION | Version of CKAN to use. | 2.9
CKAN_VERSION | Version of CKAN to use. | 2.10
COMPOSE_FILE | docker-compose service description file. | docker-compose.yml
6 changes: 2 additions & 4 deletions ckanext/datagovtheme/blueprint.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
from future import standard_library
standard_library.install_aliases()

import urllib.parse
import ckan.plugins as p
from ckan.plugins.toolkit import config
from ckan.lib.base import c, request, abort
from ckan.lib.base import abort
from ckan.common import c, request

from flask import Blueprint, redirect

Expand Down
Loading