CKAN 2.10 + Cypress 12.10.0 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FuhuXia I need help. One of the datasets in the test is being created a private and we don't know why or how. Can you take a look at it and see if you find anything? Or can we pair at some point? |
modify the create_dataset function to return the real ID so that it knows where to go
See PR comment for breaking change comments
This prevents an error that the user/group already exists
- Lots and lots and lots and lots... of changes.. - Migrate from cypress 7.3.0 to 12.10.0 - Add command to run cypress locally (courtesy of @FuhuXia) - Update tests to not be dependent on dataset name (since CKAN 2.10 breaks dataset name consistency) - Reorg cypress layout due to pre-10.0 and post-10.0 folder structuring changes
|
Tests are passing.. TODO:
|
I don't like this, but it works?
Not sure what changed, why it changed, how it changed... for what reason, it changed.. BUUUT this fixes the order_by dropdown menu on any page that inherits the 'search_form.html' snippet
landing page (pagination, count_number size, source_type), harvester (source type list, harvest_job result list ), padding between line and title/search box
|
Looks good and ready to be released as version='0.2.0', |
|
manually publish to PYPI version 0.2.0. |
I don't think we need any of this because we got rid of the 'open with' plotly stuff
| @@ -18,6 +18,13 @@ | |||
| background-color: transparent; | |||
| border: 0; | |||
| } | |||
| .hide { | |||
There was a problem hiding this comment.
anyone know the reason for this alt CSS file?
There was a problem hiding this comment.
Apparently CKAN CSS messed with Data.gov theme CSS and USWDS CSS... this is where we use it @btylerburton
ckanext/datagovtheme/templates/header-site-usage.html:3:<a href="#content" class="hide">{{ _('Skip to content') }}</a>
ckanext/datagovtheme/templates/header-site-usage.html:18: <label class="hide" for="search-header">Search for:</label>
ckanext/datagovtheme/templates/package/search.html:15: <label for="search-big" class="hide">{{ _('Search datasets') }}</label>
ckanext/datagovtheme/templates/package/search.html:124: <label for="field-location" class="hide">{{ _('Filter by location') }}</label>
ckanext/datagovtheme/templates/header.html:63:<a href="#content" class="hide">{{ _('Skip to content') }}</a>
ckanext/datagovtheme/templates/header.html:104: <li class="usa-nav__primary-item desktop-hide">| @@ -8,15 +8,15 @@ | |||
| {% snippet 'snippets/sort_by.html', sort=c.sort_by_selected %} | |||
|
|
|||
| #} | |||
| <span class="form-select {{ 'form-group' }} control-order-by"> | |||
| <div class="form-group control-order-by"> | |||
There was a problem hiding this comment.
what's the template tags for? {{ 'form-group'}}
also, looks like we deleted form-select??
The new template feature of 'super' inheritance recreates the dependency on geodatagov
…over reactions on the job list page
changed 'errors' label color and hover reactions
btylerburton
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Changes:
IRoutesis deprecated and it wasn't doing anything for us sinceCKAN 2.9.5urltourl_forh.flash.pop_messagesis deprecated and replaced withh.get_flashed_messagesorganization_readto new way oforganization.read... et cetera.h.new_activitiesis deprecated, so remove code.12.10.0(EACH DEVELOPER NEEDS TO UPDATE THEIR LOCAL SETUP)CKAN 2.10dataset name inconsistencydatagovtheme.cssresource_preview_customfunction.h.resource_previewwas mysteriously deleted in CKAN 2.10icon-???tofa-???collection_resourcesinheritance betweendatagovthemeandgeodatagov(not sure why it broke in CKAN 2.10)templates/snippets/search_form.htmlckanext-spatialfor extension testing