LG-12805 verify your id in person #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svalexander
changed the title
rutvigupta-design
suggested changes
Apr 11, 2024
There was a problem hiding this comment.
@svalexander everything looks right to me except one tiny thing in the French translations. In the second section (under Commencez cette procédure sur Login.gov avant de vous rendre au bureau de poste), I think we're missing the closing "»" and there's an extra space after "de poste". Tried highlighting this but let me know if you have any questions! Noting that this is missing in the translations document!
|
@rutvigupta-design should it look like this? |
|
@svalexander yes perfect, it should look like that! |
|
@rutvigupta-design ok awesome, i just pushed up that change |
aduth
reviewed
Apr 12, 2024
content/_help/verify-your-identity/verify-your-identity-in-person._fr.md
Outdated
Show resolved
Hide resolved
aduth
reviewed
Apr 12, 2024
content/_help/verify-your-identity/verify-your-identity-in-person._fr.md
Show resolved
Hide resolved
svalexander
force-pushed
the
shannon/lg-12805-verify-your-id-in-person
branch
from
ee93d48 to
0961dd6
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
* add en strings for verify your id in person pg * add es translations for verify your id in person pg * add fr translations for verify your id in person pg * update fr translation * add space btwn paragraphs * add another space btwn paragraphs * Testing gpg signing * Testing gpg signing again * Testing gpg signing * Testing gpg signing again
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
* add en strings for verify your id in person pg * add es translations for verify your id in person pg * add fr translations for verify your id in person pg * update fr translation * add space btwn paragraphs * add another space btwn paragraphs * Testing gpg signing * Testing gpg signing again * Testing gpg signing * Testing gpg signing again
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
* add en strings for verify your id in person pg * add es translations for verify your id in person pg * add fr translations for verify your id in person pg * update fr translation * add space btwn paragraphs * add another space btwn paragraphs * Testing gpg signing * Testing gpg signing again * Testing gpg signing * Testing gpg signing again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
LG-12805
📜 Testing Plan
Provide a checklist of steps to confirm the changes.