[F3D] [Bugfix] Fix Sync Optimization for Mat Bleed #487
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusyoshi54
added
bug
|
confirmed working and fixing the crashes |
|
Is there any reason this is based on binary fix pr? |
|
I was testing that and did the git switch thingy haha
…On Wed, Dec 25, 2024, 5:03 PM Lila ***@***.***> wrote:
Is there any reason this is based on binary fix pr?
—
Reply to this email directly, view it on GitHub
<#487 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTTURTZ4ZOLZWRHFSCN3232HMTU7AVCNFSM6AAAAABUFM2MC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRSGAYDSMBRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jesusyoshi54
force-pushed
the
bleed_opt_sync_fix
branch
from
0f0d1b7 to
4971f69
Compare
|
force pushed to rebase to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the offending function, materials were checked for any "DP" type gbi macro, and if there were none, the pipe sync was removed. The issue with this is that the DL for tesxture loading was a separate GfxList, so pipe syncs were removed if textures were loaded by no material changes occured.