Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SM64] Bring binary dl exporter up-to-date #459

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SM64] Bring binary dl exporter up-to-date #459

wants to merge 2 commits into from

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Sep 15, 2024

  • Add bleed and inline support.
  • Assert for fmeshes len
  • No longer use getDrawLayerV3, yes it doesn´t matter here but it was the last bit of code to use it, with permission I'd like to remove the function

@Lilaa3
[SM64] Bring binary dl exporter up-to-date
5a907cd 
Add bleed and inline support.
Assert for fmeshes len
No longer use getDrawLayerV3, yes it doesn´t matter here but it was the last bit of code to use it, with permission I'd like to remove the function
@jesusyoshi54 jesusyoshi54 added the sm64 Has to do with the Super Mario 64 side label Jan 9, 2025
jesusyoshi54
jesusyoshi54 requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with insertable binary and direct binary export and they work as expected.
Besides the requested changes I see no issue with the code.

fast64_internal/sm64/sm64_f3d_writer.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusyoshi54 jesusyoshi54 jesusyoshi54 approved these changes

Assignees
No one assigned
Labels
sm64 Has to do with the Super Mario 64 side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lilaa3 @jesusyoshi54