[SM64] Custom level script and special commands and improvements to custom geo commands #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed hacks, world is better now |
jesusyoshi54
added
enhancement
| if self.parameter is not None: | ||
| arg_groups.append(f"/*param*/ {self.parameter}") | ||
| if len(str(arg_groups)) > 100: | ||
| seperator = ",\n" + ("\t" * (depth + 1)) |
There was a problem hiding this comment.
it makes no sense to add a _depth arg to all the associated macro functions and then only use it in this one specific instance. There likely is a better way of determining the proper amount of tabs to be used.
There was a problem hiding this comment.
Open to suggestions, I'm not checking the function signature that's for sure
| @@ -380,9 +380,9 @@ def to_binary(self, segmentData): | |||
|
|
|||
| def to_c(self, depth): | |||
| if self.node is not None: | |||
| nodeC = self.node.to_c() | |||
| nodeC = self.node.to_c(depth) | |||
There was a problem hiding this comment.
why do this, it seems to me that the depth argument is never used by any "node" type object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom geo (in levels) replaced with custom object type which can export as special, level or geo, logic is shared across these.
New custom type is more advanced with automatic translation, rotation, scale, matrix and a color option (requested)!
Also adds depth arg to geolayouts and level/collision objects so bigger custom command are readable, along with removing commas and new lines and commas from those and adding them in the respective loops