Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Release SID on router deletion (backport #17913) #18022

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 5, 2025

Closes #15753 .

We need to call sid_unregister() in order to release a SID, which is called from the delete_vrf_tovpn_sid() and vpn_leak_postchange(). The problem is that vpn_leak_postchange() seems not to be called when we delete a router. I only see calls to vpn_leak_prechange() in bgp_delete(). It also seems that calling the whole postchange there would be incorrect.


This is an automatic backport of pull request #17913 done by [Mergify](https://mergify.com).

Signed-off-by: Mikhail Sokolovskiy <[email protected]>
(cherry picked from commit f3680ab)

# Conflicts:
#	bgpd/bgpd.c
Signed-off-by: Mikhail Sokolovskiy <[email protected]>
(cherry picked from commit 90fe717)

# Conflicts:
#	tests/topotests/bgp_srv6_sid_reachability/test_bgp_srv6_sid_reachability.py
@mergify mergify bot added the conflicts label Feb 5, 2025
Copy link
Author

mergify bot commented Feb 5, 2025

Cherry-pick of f3680ab has failed:

On branch mergify/bp/stable/10.0/pr-17913
Your branch is up to date with 'origin/stable/10.0'.

You are currently cherry-picking commit f3680ab41.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bgpd/bgpd.c

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of 90fe717 has failed:

On branch mergify/bp/stable/10.0/pr-17913
Your branch is ahead of 'origin/stable/10.0' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 90fe71735.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   tests/topotests/bgp_srv6_sid_reachability/test_bgp_srv6_sid_reachability.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@frrbot frrbot bot added the bgp label Feb 5, 2025
@ton31337 ton31337 closed this Feb 5, 2025
@ton31337 ton31337 deleted the mergify/bp/stable/10.0/pr-17913 branch February 5, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants