bgpd: Release SID on router deletion #17913
Open
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Sokolovskiy <[email protected]>
Sokolmish
force-pushed
the
bgp-sid-release
branch
from
7b2ec7a to
6899edd
Compare
|
CI:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15753 .
We need to call
sid_unregister()in order to release a SID, which is called from thedelete_vrf_tovpn_sid()andvpn_leak_postchange(). The problem is thatvpn_leak_postchange()seems not to be called when we delete a router. I only see calls tovpn_leak_prechange()inbgp_delete(). It also seems that calling the whole postchange there would be incorrect.