Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix add label support to EVPN AD routes (backport #17985) #18008

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 4, 2025

When peering with an EVPN device from other vendor, FRR acting as route reflector is not able to read nor transmit the label value.

Actually, EVPN AD routes completely ignore the label value in the code, whereas in some functionalities like evpn-vpws, it is authorised to carry and propagate label value.

Fix this by handling the label value.


This is an automatic backport of pull request #17985 done by Mergify.

When peering with an EVPN device from other vendor, FRR acting as route
reflector is not able to read nor transmit the label value.

Actually, EVPN AD routes completely ignore the label value in the code,
whereas in some functionalities like evpn-vpws, it is authorised to
carry and propagate label value.

Fix this by handling the label value.

Signed-off-by: Philippe Guibert <[email protected]>
(cherry picked from commit 1cefe94)

# Conflicts:
#	bgpd/bgp_evpn_mh.c
@mergify mergify bot added the conflicts label Feb 4, 2025
Copy link
Author

mergify bot commented Feb 4, 2025

Cherry-pick of 1cefe94 has failed:

On branch mergify/bp/stable/10.1/pr-17985
Your branch is up to date with 'origin/stable/10.1'.

You are currently cherry-picking commit 1cefe94dd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bgpd/bgp_evpn_mh.c

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ton31337
Copy link
Member

ton31337 commented Feb 4, 2025

Replaced by #18016.

@ton31337 ton31337 closed this Feb 4, 2025
@ton31337 ton31337 deleted the mergify/bp/stable/10.1/pr-17985 branch February 4, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants