Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global css #30

Merged
merged 3 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions global-styles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
* {
font-family: "Spoqa Han Sans Neo", "Noto Sans KR", sans-serif;
}

*,
*::before,
*::after {
box-sizing: border-box;
}

a {
text-decoration: none;
color: inherit;
background: none;
border: none;
font: inherit;
margin: 0;
padding: 0;
cursor: pointer;
}

a:visited {
color: inherit;
}

a:hover {
color: inherit;
text-decoration: none;
}

a:active {
color: inherit;
}

a:focus {
outline: none;
}

html {
scroll-behavior: smooth;
}
20 changes: 10 additions & 10 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,30 @@
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>placeholder title</title>
<seo-meta-tag title="Dale Study Group Website" description="This is a Dale Study Group Website"></seo-meta-tag>
<seo-meta-tag
title="Dale Study Group Website"
description="This is a Dale Study Group Website"
></seo-meta-tag>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="stylesheet" href="./styles.css" />

<link rel="stylesheet" href="./global-styles.css" />
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:[email protected]&display=swap"
rel="stylesheet"
/>
<link
href="//spoqa.github.io/spoqa-han-sans/css/SpoqaHanSansNeo.css"
rel="stylesheet"
href="https://cdn.jsdelivr.net/gh/spoqa/spoqa-han-sans/css/SpoqaHanSansNeo.css"
Comment on lines +22 to -19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹폰트 내려받는 URL은 어떤 연유로 바꾸게 되는지 궁금하네용.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공식 홈페이지에서 권유하는 대로 설정해서 더 신뢰있다고 판단했습니당

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

처음에 저 jsDelivr URL은 어떻게 발견하신 거에요? 그냥 궁금해서 ㅎㅎ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamTheKorean 이 질문에 답해주실 수 있나요?! 제가 추가한 게 아니라서 ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보통 공식홈페이지에서 가져오는데 그게 아니라면 chatgpt를 의심해봅니다..! 더 신중히 채크하도록 하겠습니다!

type="text/css"
/>

<script src="https://code.iconify.design/iconify-icon/2.1.0/iconify-icon.min.js"></script>
<script src="./main.js" async defer type="module"></script>
</head>
<body>

<style>
html {
font-size: 62.5%;
}

body {
font-family: 'Spoqa Han Sans Neo', sans-serif;
width: 80%;
margin-left: auto;
margin-right: auto;
Expand Down Expand Up @@ -233,6 +232,7 @@
}
</style>
</head>

<body>
<header>
<div>
Expand Down
15 changes: 0 additions & 15 deletions styles.css

This file was deleted.