feat: add global css #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove duplicated body and head tags - format little code styles
DaleSeo
approved these changes
Jun 11, 2024
Comment on lines
+22
to
-19
| href="//spoqa.github.io/spoqa-han-sans/css/SpoqaHanSansNeo.css" | ||
| rel="stylesheet" | ||
| href="https://cdn.jsdelivr.net/gh/spoqa/spoqa-han-sans/css/SpoqaHanSansNeo.css" |
There was a problem hiding this comment.
웹폰트 내려받는 URL은 어떤 연유로 바꾸게 되는지 궁금하네용.
There was a problem hiding this comment.
이 공식 홈페이지에서 권유하는 대로 설정해서 더 신뢰있다고 판단했습니당
There was a problem hiding this comment.
처음에 저 jsDelivr URL은 어떻게 발견하신 거에요? 그냥 궁금해서 ㅎㅎ
There was a problem hiding this comment.
@SamTheKorean 이 질문에 답해주실 수 있나요?! 제가 추가한 게 아니라서 ...
There was a problem hiding this comment.
보통 공식홈페이지에서 가져오는데 그게 아니라면 chatgpt를 의심해봅니다..! 더 신중히 채크하도록 하겠습니다!
- set styles of - a tag - font family - scroll behavior - box sizing
sounmind
force-pushed
the
evan/add-global-styles
branch
from
8baa761 to
5ac7a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close Create Global CSS #10
add global-styles.css file
fix html wrong structure