-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for token only authentication in db selection and check if credentials are valid. #177
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #177 +/- ##
==========================================
- Coverage 81.59% 81.41% -0.18%
==========================================
Files 12 12
Lines 576 592 +16
==========================================
+ Hits 470 482 +12
- Misses 106 110 +4 ☔ View full report in Codecov by Sentry. |
…et new user (required if switch from user+pw to token only).
@@ -94,4 +103,29 @@ def check_credentials(db_name: str) -> bool: | |||
Returns: | |||
TRUE if credentials were found, FALSE otherwise. | |||
""" | |||
return get_user(db_name) != "" and get_pw(db_name) != "" | |||
return get_user(db_name) != "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change now ensures that we are fine with either user + password or user only (if token is used).
Of course, this does not check whether the credentials are valid.
However, we check the validity of the credentials when they are set with the functions set_credentials etc., so I opted to not check them here again. Otherwise, we would call the /logincheck endpoint each time the user wants to get a table.
What do you think @pmayd ?
from x import y
toimport y
in some cases to prevent circular import errors.