-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Genesis API Tokens #169
Comments
I think there are a couple of options here:
Although option 2 seems to be the cleaner approach, I prefer option 1 for simplicity reasons. What do you think @pmayd ? |
I was first thinking one would be enough and simplistic but then I thought that the user should get an info if the credentials he or she entered are invalid so I think we should actually call check login for any new set_credentials and check what the user entered. This will not help if the user is changing the config directly but I think that is fine as this requires advanced knowledge anyway. So I would actually prefer to make this part of the set_credentials function |
Alright I will give it a try :) |
I opened a PR that addresses this issue: #177 |
Currently, the
check_credentials
function, called during selecting the databaseselect_db_by_credentials
(both in db), requires username and password to be set. However, this logic does not support token-based authentication for the GENESIS databases.Suggestion(s):
is_token(username)
function (by the length of the username...?) ORget_token(db_name)
function.The text was updated successfully, but these errors were encountered: