Autocomplete attribute on login, register and password_reset #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gers what kind of password to use
|
My apologies I forgot about this PR |
|
It looks like autocomplete has been part of the form for a long time. |
|
I think it's okay to remove autocomplete=off. If I had to guess, I likely just copied the HTML from some bootstrap documentation and it just never got removed. Thank you for reporting the issue. |
|
Hi @ColdHeat, thanks for processing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small improvement for the input fields on the
login,registerandpassword_resetpages.It signals password managers to use
current-passwordfor loginnew-passwordfor register and password_resetSee documentation for the autocomplete attribute here:
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#new-password
Warning
The forms on all three pages currently have
autocomplete="off". It is unclear to me why this is the case, but this PR will have no effect as long as autocompletion is turned off at the form level.