Autocomplete attribute on login, register and password_reset (#100)

* fix(autocomplete): use autocomplete attribute to signal password managers what kind of password to use * format: restored original formatting * Remove autocomplete=off from login,register,reset_password --------- Co-authored-by: Kevin Chung <[email protected]>
CTFd · Jan 31, 2025 · 7382ca5 · 7382ca5
1 parent 6e79bf3
commit 7382ca5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/templates/login.html b/templates/login.html
@@ -23,15 +23,15 @@ <h1>
         {% endif %}
 
         {% with form = Forms.auth.LoginForm() %}
-          <form method="post" accept-charset="utf-8" autocomplete="off">
+          <form method="post" accept-charset="utf-8">
             <div class="mb-3">
               <b>{{ form.name.label(class="form-label") }}</b>
-              {{ form.name(class="form-control", value=name) }}
+              {{ form.name(class="form-control", value=name, autocomplete="username email") }}
             </div>
 
             <div class="mb-3">
               <b>{{ form.password.label(class="form-label") }}</b>
-              {{ form.password(class="form-control", value=password) }}
+              {{ form.password(class="form-control", value=password, autocomplete="current-password") }}
             </div>
 
             <div class="row pt-3">

diff --git a/templates/register.html b/templates/register.html
@@ -26,27 +26,27 @@ <h1>
 
           {% from "macros/forms.html" import render_extra_fields %}
 
-          <form method="post" accept-charset="utf-8" autocomplete="off" role="form">
+          <form method="post" accept-charset="utf-8" role="form">
 
             <div class="mb-3">
               <b>{{ form.name.label(class="form-label") }}</b>
-              {{ form.name(class="form-control", value=name) }}
+              {{ form.name(class="form-control", value=name, autocomplete="username") }}
               <small class="form-text text-muted">
                 {% trans %}Your username on the site{% endtrans %}
               </small>
             </div>
 
             <div class="mb-3">
               <b>{{ form.email.label(class="form-label") }}</b>
-              {{ form.email(class="form-control", value=email) }}
+              {{ form.email(class="form-control", value=email, autocomplete="email") }}
               <small class="form-text text-muted">
                 {% trans %}Never shown to the public{% endtrans %}
               </small>
             </div>
 
             <div class="mb-3">
               <b>{{ form.password.label(class="form-label") }}</b>
-              {{ form.password(class="form-control", value=password) }}
+              {{ form.password(class="form-control", value=password, autocomplete="new-password") }}
               <small class="form-text text-muted">
                 {% trans %}Password used to log into your account{% endtrans %}
               </small>

diff --git a/templates/reset_password.html b/templates/reset_password.html
@@ -16,14 +16,14 @@ <h1>
 
         {% if mode == "set" %}
           {% with form = Forms.auth.ResetPasswordForm() %}
-            <form method="post" accept-charset="utf-8" autocomplete="off" role="form" class="form-horizontal">
+            <form method="post" accept-charset="utf-8" role="form" class="form-horizontal">
               <p>
                 {% trans %}You can now reset the password for your account and log in. Please enter in a new password below.{% endtrans %}
               </p>
 
               <div class="mb-3">
                 {{ form.password.label(class="form-label") }}
-                {{ form.password(class="form-control") }}
+                {{ form.password(class="form-control", autocomplete="new-password") }}
               </div>
 
               <div class="row pt-3">