Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Enforce HTTP methods in module controller #81

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

konhill
Copy link
Contributor

@konhill konhill commented Jan 21, 2025

No description provided.

Copy link

codeclimate bot commented Jan 21, 2025

Code Climate has analyzed commit 9f216e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 0.0% (0.0% change).

View more on Code Climate.

@coveralls
Copy link
Collaborator

coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 12923712028

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Controller/MailqueueModuleController.php 0 1 0.0%
Totals Coverage Status
Change from base Build 12923587302: 0.0%
Covered Lines: 0
Relevant Lines: 706

💛 - Coveralls

@eliashaeussler eliashaeussler added the bug Something isn't working label Jan 22, 2025
Copy link
Member

@eliashaeussler eliashaeussler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @konhill, thank you very much for the PR. I made a few suggestions. In addition, I'd categorize this change as maintenance task rather than bugfix. Would you be so kind and address the requested changes? Thanks in advance!

Classes/Controller/MailqueueModuleController.php Outdated Show resolved Hide resolved
Classes/Controller/MailqueueModuleController.php Outdated Show resolved Hide resolved
Classes/Controller/MailqueueModuleController.php Outdated Show resolved Hide resolved
@eliashaeussler eliashaeussler added maintenance Code base is being maintained and removed bug Something isn't working labels Jan 22, 2025
@eliashaeussler eliashaeussler self-assigned this Jan 22, 2025
@eliashaeussler eliashaeussler changed the title [BUGFIX] enforcing http methods [TASK] Enforce HTTP methods in module controller Jan 22, 2025
@eliashaeussler
Copy link
Member

eliashaeussler commented Jan 22, 2025

💡 One more thing: We should adapt the dependency constraints of TYPO3 extensions to require at least those versions which contain the newly introduced trait:

composer.json

"typo3/cms-*": "~11.5.42 || ~12.4.25 || ~13.4.3"

ext_emconf.php

'typo3' => '11.5.42-13.4.99'

@eliashaeussler eliashaeussler merged commit 5254a0b into main Jan 23, 2025
26 of 27 checks passed
@eliashaeussler eliashaeussler deleted the bugfix/enforcing-http-methods branch January 23, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code base is being maintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants