Merge pull request #81 from CPS-IT/bugfix/enforcing-http-methods

[TASK] Enforce HTTP methods in module controller
CPS-IT · Jan 23, 2025 · 5254a0b · 5254a0b
2 parents 028fb1c + 9f216e7
commit 5254a0b
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 47 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -44,6 +44,13 @@ jobs:
       - name: Start MySQL
         run: sudo /etc/init.d/mysql start
 
+      # Configure TYPO3 ELTS
+      - name: Add ELTS repository
+        run: |
+          composer config repositories.typo3-elts composer https://elts.typo3.com
+          composer config http-basic.elts.typo3.com ${{ secrets.TYPO3_ELTS_USERNAME }} ${{ secrets.TYPO3_ELTS_PASSWORD }}
+        if: ${{ matrix.typo3-version == '11.5' }}
+
       # Install dependencies
       - name: Install Composer dependencies
         uses: ramsey/composer-install@v3

diff --git a/Classes/Controller/MailqueueModuleController.php b/Classes/Controller/MailqueueModuleController.php
@@ -43,6 +43,7 @@
 final class MailqueueModuleController
 {
     use Traits\TranslatableTrait;
+    use Core\Http\AllowedMethodsTrait;
 
     private readonly Core\Information\Typo3Version $typo3Version;
 
@@ -59,6 +60,8 @@ public function __construct(
 
     public function __invoke(Message\ServerRequestInterface $request): Message\ResponseInterface
     {
+        $this->assertAllowedHttpMethod($request, 'GET', 'POST');
+
         $template = $this->moduleTemplateFactory->create($request);
         $transport = $this->mailer->getTransport();
         $page = $this->resolvePageIdFromRequest($request);

diff --git a/composer.json b/composer.json
@@ -18,9 +18,9 @@
 		"symfony/console": "^5.4 || ^6.4 || ^7.0",
 		"symfony/mailer": "^5.4 || ^6.4 || ^7.0",
 		"symfony/mime": "^5.4 || ^6.4 || ^7.0",
-		"typo3/cms-backend": "~11.5.0 || ~12.4.0 || ~13.4.0",
-		"typo3/cms-core": "~11.5.0 || ~12.4.0 || ~13.4.0",
-		"typo3/cms-fluid": "~11.5.0 || ~12.4.0 || ~13.4.0",
+		"typo3/cms-backend": "~11.5.42 || ~12.4.25 || ~13.4.3",
+		"typo3/cms-core": "~11.5.42 || ~12.4.25 || ~13.4.3",
+		"typo3/cms-fluid": "~11.5.42 || ~12.4.25 || ~13.4.3",
 		"typo3fluid/fluid": "^2.15 || ^4.0"
 	},
 	"require-dev": {
@@ -35,7 +35,7 @@
 		"phpunit/phpcov": "^9.0 || ^10.0",
 		"saschaegerer/phpstan-typo3": "^1.10",
 		"ssch/typo3-rector": "^2.0",
-		"typo3/cms-lowlevel": "~11.5.0 || ~12.4.0 || ~13.4.0",
+		"typo3/cms-lowlevel": "~11.5.42 || ~12.4.25 || ~13.4.3",
 		"typo3/coding-standards": "^0.7.0 || ^0.8.0",
 		"typo3/testing-framework": "^7.0.2 || ^8.0.9 || ^9.0.1"
 	},

diff --git a/composer.lock b/composer.lock
diff --git a/ext_emconf.php b/ext_emconf.php
@@ -32,7 +32,7 @@
     'author_company' => 'coding. powerful. systems. CPS GmbH',
     'constraints' => [
         'depends' => [
-            'typo3' => '11.5.0-13.4.99',
+            'typo3' => '11.5.42-13.4.99',
             'php' => '8.1.0-8.4.99',
         ],
     ],