Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #421 #422

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix issue #421 #422

merged 1 commit into from
Jan 28, 2025

Conversation

CarlosCancino-Chacon
Copy link
Member

This pull fixes issue #421.

It includes the following changes:

  • Fixes a minor typo in the __eq__ method in PerformedNote
  • Adds tests for PerformedNote

@CarlosCancino-Chacon CarlosCancino-Chacon added the bug Something isn't working label Jan 28, 2025
@CarlosCancino-Chacon CarlosCancino-Chacon self-assigned this Jan 28, 2025
@manoskary manoskary linked an issue Jan 28, 2025 that may be closed by this pull request
Error checking for equality in PerformedNote #421
Closed
manoskary
manoskary approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses a bug fix in the eq method. Excellent and comprehensive tests for the PerformedNote class are added that ensure the reliability and correctness of the code.

@manoskary manoskary merged commit 9606a32 into develop Jan 28, 2025
3 checks passed
@manoskary manoskary mentioned this pull request Jan 28, 2025
Open
@CarlosCancino-Chacon CarlosCancino-Chacon deleted the bug/issue_421 branch January 28, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manoskary manoskary manoskary approved these changes

Assignees

@CarlosCancino-Chacon CarlosCancino-Chacon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error checking for equality in PerformedNote
2 participants
@CarlosCancino-Chacon @manoskary