Version 1.6.0 #398

sildater · 2024-10-31T10:59:56Z

PR for version 1.6.0

This new version addresses multiple changes, bug fixes and new features:

New features

Measure refactor for musicxml, match, midi, note array to part in Measure refactor match/midi/musicxml #376
Measure feature Measure feature #377
Clef feature Clef feature #382
Clef map Add clef map #384 Clef map testing #396
Stem direction Stem Direction Support #392
Support for cross staff voices in mei Cross staff voices #397

Bug fixes

get_time_maps_from_alignment fix issue 358 #360
correct metrical strength features fix bug, update documentation #364
correct offsets for tied notes Corrected Offsets for tied notes. #366
fix import issue Fix import for issue 348 #368
fix kern parsing Kern fixes (parsing editorials) #370
correct symbolic note duration New solution for estimate_symbolic_duration #372
fix tuplet bug Relax assertion tuplet #387

Other Changes

add check for empty note array add check for empty note array #361
improve documentation improve documentation performance note_array #362 fix bug, update documentation #364
remove default voice estimation estimate_voice_info now default to false #373
add warning Fix issue 378 #379
remove ordering in musicxml export patch issue 390 #391

Todo

some PRs are still to be merged
set new version

fix issue 358

add check for empty note array

improve documentation performance note_array

Ref issue: #365

Ref. Issue #367

fixes for two bugs during **kern import.

fix bug, update documentation

# Conflicts: # partitura/io/__init__.py # partitura/score.py

swap concatenation for hstack for numpy>1.21 compatibility

equal duration for all chord notes

Found a problematic cadence parsing while parsing large corpora for testing. I incorporate the fix on this PR since it is very minor.

Add optional attributes to tuplets related to their time modification

Replaced deprecated scipy derivative

manoskary · 2025-01-26T17:10:12Z

Updated Merge Report

below the updated notes for this PR to include most recent changes

PR for version 1.6.0

This new version addresses multiple changes, bug fixes and new features:

New features

Measure refactor for musicxml, match, midi, note array to part in Measure refactor match/midi/musicxml #376
Measure feature Measure feature #377
Clef feature Clef feature #382
Clef map Add clef map #384 Clef map testing #396
Stem direction Stem Direction Support #392
Support for cross staff voices in mei Cross staff voices #397
Improved parsing of Kern scores Updates on kern support #413
Fixed import for performance pedal Performance pedal fix #399
Tick Units are now supported for pianoroll creation add tick units #412
Scores can be loaded directly for URL Load Scores from URL #404
Support for invisible objects in musicxml import Add a parameter to ignore invisible objects when parsing MusicXML files #401
Support for Fingering annotations in MusicXML and MEI import/export Support for Fingering Annotations and Markings. #403

Bug fixes

Corrected get_time_maps_from_alignment fix issue 358 #360
Corrected metrical strength features fix bug, update documentation #364
Corrected offsets for tied notes Corrected Offsets for tied notes. #366
Fixed import issue Fix import for issue 348 #368
Fixed Kern parsing Kern fixes (parsing editorials) #370
Duration of Chord Notes equal duration for all chord notes #418
Corrected symbolic note duration New solution for estimate_symbolic_duration #372
Fixed tuplet bug Relax assertion tuplet #387
Addressed sorting for enharmonic notes Sort exported notes by step when same midi_pitch #407
Fixes eq bug on performed notes Fix issue #421 #422

Other Changes

Added check for empty note array add check for empty note array #361
Improved documentation improve documentation performance note_array #362 fix bug, update documentation #364
Removed default voice estimation estimate_voice_info now default to false #373
Added warning Fix issue 378 #379
Removed ordering in musicxml export patch issue 390 #391
Improved Fingering parsing in MusicXML that could result to errors Fix Issue #414 #416
Replaced Deprecated Scipy Function Replaced deprecated scipy derivative #417
Improved support for input and export in musicxml tuplet object
New option to force add new segments option to to force new segments in add_segments #410

option to to force new segments in `add_segments`

Fixes issue #421

huispaty

This release PR brings several valuable features and improvements:

Measure feature with full I/O support for MusicXML, MIDI, Match, and Note Array
Clef feature and an updated feature map
Stem direction processing
Cross-voice processing in MEI

Additionally, this release includes various bug fixes and enhancements.

leleogere · 2025-02-03T09:49:30Z

Support for invisible objects in musicxml import #401

There might be issues with this PR in some rare cases: as a parsing error can happen when there are invisible objects that are part of some kind of "group". For example, in #419, the parser crashes because a single note of a chord is invisible. I did not test with other types of "groups" (tuplets, beamings), but I guess it might happen too, depending on how the parser works. As long as Partitura does not have a proper way of dealing with invisible objects (such as an invisible attribute on TimedObject), I think we could add at least a warning when the user passes ignore_invisible_objects=True to load_musicxml to inform them that it might sometimes lead to parsing errors for unusual musicxml files.

Note that when ignore_invisible_objects is False (the default), the parsing works as expected as before.

CarlosCancino-Chacon and others added 30 commits April 5, 2024 16:24

parse fingering info from MusicXML

ba0266d

allow to_matched_score to use note arrays as inputs

e0ed514

added fingering support in MEI export.

10ad1a5

first draft for importing romantext annotations.

ea5bc08

some edits on Rntxt parser for import.

417c88c

Merge branch 'dcml_annotation_parser' into rntxt

4551bff

Rntxt parser first draft complete.

8a87047

minor changes on RN parser.

5b5d358

some changes and first rntxt test draft.

a71a692

Minor Changes for Roman Numeral Checking.

700474e

Better loading for rntxt format.

4e03cd1

Test case for rntxt import.

cb14c20

fix 358

eae4542

add check for empty note array

50d3343

improve documentation performance note_array

cbc9f48

Merge pull request #360 from CPJKU/fix358

d366f60

fix issue 358

Format code with black (bot)

693b2c4

Merge pull request #361 from CPJKU/fix_356

30ffdc4

add check for empty note array

Merge pull request #362 from CPJKU/fix_349

42423e0

improve documentation performance note_array

fix bug, update documentation

1e80195

Corrected Offsets for tied notes.

498995e

Ref issue: #365

Correction for staff line 2 as int.

e06b975

Ref. Issue #367

Removed unused code and added comments.

75b7213

Merge pull request #366 from CPJKU/kern_tied_offset_bug

df54d0c

fixes for two bugs during **kern import.

Merge pull request #364 from CPJKU/fix_363

9d480d9

fix bug, update documentation

Format code with black (bot)

8dccc0a

update tutorial with correct import

f532be4

Merge remote-tracking branch 'origin/develop' into rntxt

3929f98

# Conflicts: # partitura/io/__init__.py # partitura/score.py

Edits to support or remove editorials.

26d30c5

Removed unnecessary code.

0a139f2

huispaty and others added 14 commits January 21, 2025 16:09

resolve conflicts

3669127

fix indent level

f52038e

Merge branch 'develop' into xml_chord

027d700

Merge pull request #408 from CPJKU/numpy_version_fix

6762dbc

swap concatenation for hstack for numpy>1.21 compatibility

Merge pull request #418 from CPJKU/xml_chord

fe19cf9

equal duration for all chord notes

Merge branch 'develop' into add_tuplet_attributes

f882d53

Fix the tuplet attribute parser in case of actual-type != normal-type

cd0e308

updated derivative doc to reflect source and simplifications.

889f519

Fixed unrelated cadence parsing error.

72ed377

Found a problematic cadence parsing while parsing large corpora for testing. I incorporate the fix on this PR since it is very minor.

Merge pull request #414 from leleogere/add_tuplet_attributes

cb21270

Add optional attributes to tuplets related to their time modification

Format code with black (bot)

d86cd22

Added link to scipy docs.

d1f95f6

Code simplification.

6e82c27

Merge pull request #417 from CPJKU/scipy_derivative_deprecation

e204c08

Replaced deprecated scipy derivative

huispaty and others added 4 commits January 27, 2025 11:26

Merge pull request #410 from CPJKU/force-new-seg

8b06aee

option to to force new segments in `add_segments`

Format code with black (bot)

9e7c651

fix typo and add tests for PerformedNote

49023bc

Merge pull request #422 from CPJKU/bug/issue_421

9606a32

Fixes issue #421

manoskary linked an issue Jan 28, 2025 that may be closed by this pull request

Error checking for equality in PerformedNote #421

Closed

huispaty reviewed Jan 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 1.6.0 #398

Version 1.6.0 #398

sildater commented Oct 31, 2024

manoskary commented Jan 26, 2025 •

edited

Loading

huispaty left a comment

leleogere commented Feb 3, 2025

Version 1.6.0 #398

Are you sure you want to change the base?

Version 1.6.0 #398

Conversation

sildater commented Oct 31, 2024

PR for version 1.6.0

New features

Bug fixes

Other Changes

Todo

manoskary commented Jan 26, 2025 • edited Loading

Updated Merge Report

PR for version 1.6.0

New features

Bug fixes

Other Changes

huispaty left a comment

Choose a reason for hiding this comment

leleogere commented Feb 3, 2025

manoskary commented Jan 26, 2025 •

edited

Loading