Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a parameter init #56

Merged
merged 1 commit into from
Jun 4, 2024
Merged

added a parameter init #56

merged 1 commit into from
Jun 4, 2024

Conversation

SatoSan3
Copy link
Contributor

I found that you forgot to initialize the init_pf_ variable in the EMcl2Node class.
I added the initialization process, so please check it !

@kei487 kei487 requested review from kei487 and removed request for kei487 June 4, 2024 09:31
@kei487
Copy link

kei487 commented Jun 4, 2024 •
edited
Loading

Thank you for your contribution!
I have verified that initializing the init_pf_ variable doesn't exist in the CIT-Autonomous-Robot-Lab:main.
In the SatoSan3/:feature/init_pf_fix, I confirmed that it works fine with your addition.
I will proceed with merging your pull request.

@kei487 kei487 merged commit 561ef81 into CIT-Autonomous-Robot-Lab:main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kei487 kei487 kei487 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SatoSan3 @kei487