Skip to content

Commit

Permalink
CI (all workflows): rename cache check/fetch step
Browse files Browse the repository at this point in the history
Instead of use "Cache XY" use more techical "Run action/cache for XY"
(similarly as implicit name when "name" key was not used).

Although the action is really actions/cache, the problem with the previous
name is that it actually doesn't cache the named item. It checks, and
if found loads, the item. But even if the item is not found, the action
reports success in GH web UI, which is quite misleading. So using rather
neutral name for the step should slightly decrease the confusion.
  • Loading branch information
MartinPulec committed Jan 3, 2025
1 parent a4c1268 commit 40f7bb7
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/arm-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
id: etags
run: |
echo "ndi=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v5_Linux.tar.gz)" >> $GITHUB_OUTPUT
- name: Cache NDI
- name: Run actions/cache for NDI
id: cache-ndi
uses: actions/cache@main
with:
Expand All @@ -50,7 +50,7 @@ jobs:
if: steps.cache-ndi.outputs.cache-hit != 'true'
run: curl -L https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v5_Linux.tar.gz -o /var/tmp/Install_NDI_SDK_Linux.tar.gz

- name: Cache Environment
- name: Run actions/cache for ARM Chroot
id: cache-bootstrap
uses: actions/cache@main
with:
Expand All @@ -71,7 +71,7 @@ jobs:
sudo cp /usr/bin/qemu-${{ matrix.qemu_bin_arch }}-static ~/chroot/usr/bin/
sudo chroot ~/chroot /.github/scripts/Linux/arm/bootstrap.sh ${{ matrix.arch }}
cd ~ && sudo tar cf chroot.tar chroot # Create archive for caching. Needs to be created as root, therefore created manually.
- name: Extract Cached Environment
- name: Extract Cached Chroot
if: steps.cache-bootstrap.outputs.cache-hit == 'true'
run: |
cd ~
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/ccpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
id: etags
run: |
echo "ndi=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v6_Linux.tar.gz)" >> $GITHUB_OUTPUT
- name: Cache NDI
- name: Run actions/cache for NDI
id: cache-ndi
uses: actions/cache@main
with:
Expand All @@ -76,7 +76,7 @@ jobs:
run: |
. .github/scripts/environment.sh
.github/scripts/Linux/prepare.sh
- name: Cache FFmpeg
- name: Run actions/cache for FFmpeg
id: cache-ffmpeg
uses: actions/cache@main
with:
Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:
echo "ximea=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://www.ximea.com/downloads/recent/XIMEA_OSX_SP.dmg)" >> $GITHUB_OUTPUT
- name: Set environment
run: . .github/scripts/environment.sh
- name: Cache Non-Free SDKs
- name: Run actions/cache for Non-Free SDKs
id: cache-macos-nonfree-sdks
uses: actions/cache@main
with:
Expand All @@ -167,7 +167,7 @@ jobs:
mkdir -p ${{ env.SDK_NONFREE_PATH }}
cd ${{ env.SDK_NONFREE_PATH }}
curl -S -f -O "$SDK_URL/$DELTA_MAC_ARCHIVE" || true
- name: Cache XIMEA
- name: Run actions/cache for XIMEA
id: cache-macos-ximea
uses: actions/cache@main
with:
Expand All @@ -176,7 +176,7 @@ jobs:
- name: Download XIMEA
if: steps.cache-macos-ximea.outputs.cache-hit != 'true'
run: curl -S -L https://www.ximea.com/downloads/recent/XIMEA_OSX_SP.dmg -o /private/var/tmp/XIMEA_OSX_SP.dmg
- name: Cache NDI
- name: Run actions/cache for NDI
id: cache-ndi
uses: actions/cache@main
with:
Expand Down Expand Up @@ -248,7 +248,7 @@ jobs:
- name: Find MSVC
run: .github/scripts/Windows/find_msvc.ps1
shell: pwsh -command ". '{0}'"
- name: Cache NDI
- name: Run actions/cache for NDI
id: cache-ndi
uses: actions/cache@main
with:
Expand All @@ -267,7 +267,7 @@ jobs:
if: steps.cache-macos-ximea.outputs.cache-hit != 'true'
run: curl 'https://www.ximea.com/support/attachments/download/37/XIMEA_API_Installer.exe' -o 'C:\XIMEA_API_Installer.exe'

- name: Cache libajantv2 build
- name: Run actions/cache for libajantv2 build
id: cache-aja
uses: actions/cache@main
with:
Expand All @@ -283,7 +283,7 @@ jobs:
- name: bootsrap
run: .github/scripts/Windows/prepare.ps1
shell: pwsh -command ". '{0}'"
- name: Cache JACK
- name: Run actions/cache for JACK
id: cache-jack
uses: actions/cache@main
with:
Expand All @@ -296,7 +296,7 @@ jobs:
- name: bootsrap MSYS2
run: $GITHUB_WORKSPACE/.github/scripts/Windows/prepare_msys.sh

- name: Cache Spout build
- name: Run actions/cache for Spout build
id: cache-spout
uses: actions/cache@main
with:
Expand All @@ -308,7 +308,7 @@ jobs:
- name: Install Spout
run: $GITHUB_WORKSPACE/.github/scripts/Windows/install_spout.sh install

- name: Cache CineForm build
- name: Run actions/cache for CineForm build
id: cache-cineform
uses: actions/cache@main
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverity-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
run: |
FILENAME=$(curl -LI "https://scan.coverity.com/download/linux64?token=$coverity_token&project=UltraGrid" | sed -n '/content-disposition/s/.*\"\(.*\)\"/\1/p')
echo "filename=$FILENAME" >> $GITHUB_OUTPUT
- name: Cache Coverity build tool
- name: Run actions/cache for Coverity build tool
if: ${{ env.coverity_token }}
id: cache-coverity-tool
uses: actions/cache@main
Expand All @@ -47,7 +47,7 @@ jobs:
id: etags
run: |
echo "ndi=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v6_Linux.tar.gz)" >> $GITHUB_OUTPUT
- name: Cache NDI
- name: Run actions/cache for NDI
if: ${{ env.coverity_token }}
id: cache-ndi
uses: actions/cache@main
Expand Down

0 comments on commit 40f7bb7

Please sign in to comment.