Skip to content

Commit

Permalink
ARM CI: use GH runner ubuntu-22.04
Browse files Browse the repository at this point in the history
Use runner ubuntu-22.04 instead of ubuntu-latest. Because ubuntu-latest
has switched to ubuntu-24.04 recently, whiich breaks the build for arm64.

There seem to be an unresolved bug in QEMU >= 8.1
(U24.04 has v8.2.2) when using ARM64 and bullseye:
<https://gitlab.com/qemu-project/qemu/-/issues/2377>.

(ARM64 buster and bookworm, as well as ARMHF, may be fine as indicated
in the bug description.)

This can be reverted later (either when fixed in QEMU or when switched
the chroot to bookworm). But it shouldn't matter much, anyways, since this
is just the "host" environment.

Also include runner ver in chroot key because it seem to make a difference
from the above..
  • Loading branch information
MartinPulec committed Jan 3, 2025
1 parent 22c800d commit a4c1268
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/scripts/environment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ if ! is_arm; then
fi

printf '%b' "FEATURES=$FEATURES\n" >> "$GITHUB_ENV"
# populate /etc/environment-defined var to global env
# shellcheck disable=SC2154 # defined by runner in /etc/environment
printf '%b' "ImageOS=$ImageOS\n" >> "$GITHUB_ENV"

if [ "$(uname -s)" = Darwin ] && [ "$(uname -m)" != arm64 ]; then
export UG_ARCH=-msse4.2
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/arm-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
jobs:
Build:
if: github.repository == 'CESNET/UltraGrid' || github.event.schedule == null
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # TODO: see the commit message why 22.04 is explicit
strategy:
matrix:
arch: [armhf, arm64]
Expand Down Expand Up @@ -55,7 +55,9 @@ jobs:
uses: actions/cache@main
with:
path: '~/chroot.tar'
key: cache-bootstrap-${{ matrix.arch }}-${{ hashFiles('.github/scripts/Linux/arm/bootstrap.sh', '.github/scripts/Linux/install_others.sh') }}
key: cache-bootstrap-${{ env.ImageOS }}-${{ matrix.arch }}-${{
hashFiles('.github/scripts/Linux/arm/bootstrap.sh',
'.github/scripts/Linux/install_others.sh') }}
- name: Debootstrap
if: steps.cache-bootstrap.outputs.cache-hit != 'true'
run: |
Expand Down

0 comments on commit a4c1268

Please sign in to comment.