ENH: Fixes high memory consumption in SurfaceNets Filter #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
imikejackson
commented
Dec 6, 2024
imikejackson
commented
- DOC: Fixes incorrect human name for QuickMesh filter
- MEM: Reduces memory usage for SurfaceNets filter
- SPELL: Fixes misspellings in human facing error messages
nyoungbq
requested changes
Dec 6, 2024
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.h
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.h
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.h
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/SurfaceNets/MMCellFlag.cpp
Outdated
Show resolved
Hide resolved
JDuffeyBQ
force-pushed
the
topic/surface_nets_memory_fixes
branch
from
fd9078b to
433707c
Compare
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
This reverts commit 440920e.
* Reduced memory usage of SurfaceNets algorithm which uses MMCellFlag * Changed constants to class static variables * Removed unneeded virtual Signed-off-by: Jared Duffey <[email protected]>
imikejackson
force-pushed
the
topic/surface_nets_memory_fixes
branch
from
433707c to
ed97731
Compare
Signed-off-by: Jared Duffey <[email protected]>
* The number of junctions can be at most 6 so it can be stored in 3 bits and m_BitFlag has enough unused bits at the end to accommodate it Signed-off-by: Jared Duffey <[email protected]>
nyoungbq
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.