Complete the low-level wrapper of all used HDF5 functions. #863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrapper enables us to see more easily notice that an error code is being ignored, makes it very clear how we wrap HDF5 function and encourages us to not ignore unchecked error codes if we see one. It'll make it easier to have uniform error handling. Additionally, it prepares the way towards more interesting features, such as thread-safety or logging each call to HDF5 (for creating pure HDF5 reproducers).
The rules are:
H5?*
is wrapped bydetail::h5?_*
. We can't reuse the name in a namespace because some of them are macros.detail::nothrow
it'll throw whenever the returned value indicates an error.H5?*
anddetail::h5?_*
are identical.h5?_wrapper.hpp
we don't use any HDF5 functions or function macros.