Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap all used H5P functions. #887

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Wrap all used H5P functions. #887

merged 1 commit into from
Dec 7, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 7, 2023

No description provided.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (dfa3801) 84.98% compared to head (8f10a7b) 85.13%.

Files Patch % Lines
include/highfive/bits/h5p_wrapper.hpp 80.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   84.98%   85.13%   +0.15%     
==========================================
  Files          76       77       +1     
  Lines        5294     5396     +102     
==========================================
+ Hits         4499     4594      +95     
- Misses        795      802       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review December 7, 2023 07:38
@1uc 1uc merged commit f419ae3 into master Dec 7, 2023
36 checks passed
@1uc 1uc deleted the 1uc/h5p_wrapper branch December 7, 2023 10:09
@1uc
Copy link
Collaborator Author

1uc commented Dec 12, 2023

This splits out a reviewable chunk from #863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants