Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable scenario termination from closing display #238

Closed
wants to merge 2 commits into from

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented Apr 18, 2024

Description

Fix that allows users to manually close out display via the UI and continue subsequent simulations to continue. Here is a video illustrating the working changes

pygame_fixed.mov

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin April 18, 2024 20:48
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.96%. Comparing base (0232e6f) to head (bde9c32).

Files Patch % Lines
src/scenic/simulators/newtonian/simulator.py 60.00% 2 Missing ⚠️
src/scenic/core/simulators.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         144      144           
  Lines       24768    24777    +9     
=======================================
+ Hits        21292    21300    +8     
- Misses       3476     3477    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abanuelo abanuelo closed this Apr 25, 2024
@abanuelo abanuelo deleted the abanuelo/fix-230 branch April 25, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant