Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenic only generates one scene per call #230

Open
3 tasks done
Kai-X-Org opened this issue Apr 7, 2024 · 4 comments
Open
3 tasks done

Scenic only generates one scene per call #230

Kai-X-Org opened this issue Apr 7, 2024 · 4 comments
Assignees
Labels
status: valid Issue is valid and will be worked on type: bug Something isn't working

Comments

@Kai-X-Org
Copy link
Collaborator

Kai-X-Org commented Apr 7, 2024

System Details

  1. Python 3.11.0
  2. Scenic 3.0.0b2
  3. Apple M1 Pro MacOS Ventura 13.4
  4. No simulator

Detailed Description

When running a scenic file from the command line without setting the --count flag, Scenic only generates one scene. After closing the window popped up by clicking the red x, Scenic terminates rather than generate another scene.

Steps To Reproduce

I simply ran ego = new Object in a Scenic file from the command line.

Issue Submission Checklist

  • I am reporting an issue, not asking a question
  • I checked the open issues, forum, etc. and have not found any solution
  • I have provided all necessary code, etc. to reproduce the issue
@Kai-X-Org Kai-X-Org added status: triage Issue needs to be assessed type: bug Something isn't working labels Apr 7, 2024
@ek65
Copy link
Collaborator

ek65 commented Apr 17, 2024

Hi, @Kai-X-Org, I could not replicate your error on my end.
Could you try running a scenic program in examples/webots/vacuum/vacuum_simple.scenic and see if you run into the same issue?

@Eric-Vin Eric-Vin added status: needs more info Requesting more info and removed status: triage Issue needs to be assessed labels Apr 17, 2024
@ek65 ek65 assigned ek65 and abanuelo and unassigned ek65 Apr 17, 2024
@abanuelo
Copy link
Contributor

@Eric-Vin @Kai-X-Org I have confirmed that this error exists. Namely, when you try to close out the pygame display it only generates a single simulation and when you try to close it out, it prevents you from doing so.

My script:

model scenic.simulators.newtonian.model
ego = new Object

My command:

scenic examples/carla/test.scenic \
    --2d       \
    --simulate \
    --model scenic.simulators.newtonian.model -b

Here is a video illustrating the process. Note, the only way to quit the simulation is to have a KeyboardInterrupt which is not ideal because it does not allow for subsequent simulations to continue.

pygame_error.mov

@abanuelo abanuelo added status: valid Issue is valid and will be worked on and removed status: valid Issue is valid and will be worked on status: needs more info Requesting more info labels Apr 18, 2024
@abanuelo
Copy link
Contributor

@Kai-X-Org following up on the issue, here I was able to reproduce the issue without a simulator. Also note the fix #238 above actually allows us to terminate dynamic scenarios mid-scenario so it's actually a feature and not related to the issue you indicated in this PR:

Here is the current behavior:

actual.mov

Here is the expected behavior

expected.mov

@abanuelo
Copy link
Contributor

Note, I think this may be the intended behavior for the Cocoa implementation that is used in MacOS environments by pyglet. More details can be reported in this open issue: mikedh/trimesh#2131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: valid Issue is valid and will be worked on type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants