Use Poetry for dependency management and packaging (SVRENG-252) #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alters the package to use Poetry for dependency management and packaging. Reasoning for this includes, but is not limited to, the fact that it is not really advisable to develop in an environment where the `make develop` incantation makes changes to system or user Python packages, which can quickly lead to dependency conflicts. (I've been hit by this a few times.) Resolves #63.
asullivan-blze
force-pushed
the
svreng-252-python-poetry
branch
9 times, most recently
from
b0f3a19 to
ceea820
Compare
Additionally alters the Makefile to force commands--when applicable--to run within the Poetry venv via `poetry run`.
asullivan-blze
force-pushed
the
svreng-252-python-poetry
branch
from
ceea820 to
c9bb23b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Alters the package to use Poetry for dependency management and packaging. Reasoning for this includes, but is not limited to, the fact that it is not really advisable to develop in an environment where the
make developincantation makes changes to system or user Python packages, which can quickly lead to dependency conflicts. (I've been hit by this a few times.)Resolves #63.
How was this tested?
Tested using the various
Makefilecommands to install into the Poetry venv, build the package, build the podman image, and all worked as expected.Checklist