Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what's wrong with usort and GitHub Actions #65

Closed
asullivan-blze opened this issue Mar 21, 2024 · 0 comments · Fixed by #66
Closed

Figure out what's wrong with usort and GitHub Actions #65

asullivan-blze opened this issue Mar 21, 2024 · 0 comments · Fixed by #66
Assignees
Labels
bug Something isn't working CI/CD Items affecting GitHub Actions CI/CD

Comments

@asullivan-blze
Copy link
Contributor

asullivan-blze commented Mar 21, 2024

For whatever reason, make test-usort errors with the following error when attempting to execute the following from the Makefile:

# Ensure imports are formatted in a uniform way
.PHONY: test-usort
test-usort: develop
	@# This is a workaround for https://github.com/facebook/usort/issues/216
	LIBCST_PARSER_TYPE=native poetry run usort check .

black does explicitly call out isort as being compatible, so perhaps we could switch to that as the import sorting/ordering method? Alternatively: Perhaps Ruff (combines black and isort)?

image

Spawned from #64.

@asullivan-blze asullivan-blze added bug Something isn't working CI/CD Items affecting GitHub Actions CI/CD labels Mar 21, 2024
asullivan-blze added a commit that referenced this issue Mar 25, 2024
Implements Ruff to take over code formatting, linting, and import ordering from black and usort.

Resolves #65.
@asullivan-blze asullivan-blze self-assigned this Mar 25, 2024
asullivan-blze added a commit that referenced this issue Mar 26, 2024
Implements Ruff to take over code formatting, linting, and import ordering from black and usort.

Resolves #65.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD Items affecting GitHub Actions CI/CD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant