Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadowing for LaPDXYExclusion #60

Merged
merged 63 commits into from
Jan 13, 2025
Merged

Add shadowing for LaPDXYExclusion #60

merged 63 commits into from
Jan 13, 2025

Conversation

rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Jun 14, 2024

Update LaPDXYExclusion such that a shadow exclusion region is generate if an exclusion region is inserted between the backside of the LaPD chamber and the insertion point of the probe.


Included in this PR:

  • Creation of GovernExclusion. GovernExclusion is sub-classes BaseExclusion and is sub-classed just like BaseExclusion is. There are two distinct differences between the two: (1) BaseExclusion should always generate its exclusion mask independent of the global mask while GovernExclusion can inspect the global mask to generate its exlusion mask, and (2) BaseExclusion AND's its exclusion mask with the global mask while GovernExclusion replaces the global mask with its exclusion mask.
  • Updated MotionBuilder to leverage the inclusion of GovernExclusion's. MotionBuilder only allows one GovernExclusion to be defined and it is always executed last during the building of the global mask.
  • Created exclusion layer Shadow2DExclusion. This is a GovernExclusion that will create a shadow masked base on the predefined exclusion layers in the global mask.
  • Incorporated Shadow2DExclusion into LaPDXYExclusion
    ~
  • Added jupyter notebook for Shadow2DExclusion
  • Updated notebook for LaPDXYExclusion
  • Created a dedicated prototyping notebook directory docs/notebooks/prototypes/
    ~
  • Add mask_resolution property to MBItem.
  • Restricted dependency kiwisolver < 1.4.7 to make CI tests pass. kiwisolver is a matplotlib dependency, and not ours directly.
  • Fixed a handful of syntax errors and misspellings.

rocco8773 added 30 commits March 6, 2024 12:11
… to the DataSet (skip_ds_add) ... this allows an exclusion to name its composed exclusions
…ate additional exclusion for "un-excluding" the region near the pivot/insertion point
…d to "un-exclude" the region near the pivot/insertion point
…culate the mask corresponding to shadowing existing exclusion regions
@rocco8773 rocco8773 mentioned this pull request Jan 13, 2025
7 tasks
@rocco8773 rocco8773 marked this pull request as ready for review January 13, 2025 20:56
@rocco8773 rocco8773 merged commit 89801f9 into main Jan 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant