-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shadowing for LaPDXYExclusion
#60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the DataSet (skip_ds_add) ... this allows an exclusion to name its composed exclusions
… layer is regenerated
…he pivot/insertion point
…ate additional exclusion for "un-excluding" the region near the pivot/insertion point
…d to "un-exclude" the region near the pivot/insertion point
…rray) of identified edges
…nd building the edge pool
…culate the mask corresponding to shadowing existing exclusion regions
…r of the motion space
….ipynb...and fill out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
LaPDXYExclusion
such that a shadow exclusion region is generate if an exclusion region is inserted between the backside of the LaPD chamber and the insertion point of the probe.Included in this PR:
GovernExclusion
.GovernExclusion
is sub-classesBaseExclusion
and is sub-classed just likeBaseExclusion
is. There are two distinct differences between the two: (1)BaseExclusion
should always generate its exclusion mask independent of the global mask whileGovernExclusion
can inspect the global mask to generate its exlusion mask, and (2)BaseExclusion
AND's its exclusion mask with the global mask whileGovernExclusion
replaces the global mask with its exclusion mask.MotionBuilder
to leverage the inclusion ofGovernExclusion
's.MotionBuilder
only allows oneGovernExclusion
to be defined and it is always executed last during the building of the global mask.Shadow2DExclusion
. This is aGovernExclusion
that will create a shadow masked base on the predefined exclusion layers in the global mask.Shadow2DExclusion
intoLaPDXYExclusion
~
Shadow2DExclusion
LaPDXYExclusion
docs/notebooks/prototypes/
~
mask_resolution
property toMBItem
.kiwisolver < 1.4.7
to make CI tests pass.kiwisolver
is amatplotlib
dependency, and not ours directly.