Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GovernExclusion and ConfigureGUI work together #80

Merged
merged 23 commits into from
Jan 15, 2025
Merged

Ensure GovernExclusion and ConfigureGUI work together #80

merged 23 commits into from
Jan 15, 2025

Conversation

rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Jan 15, 2025 •
edited
Loading

Modify code to ensure the functionality around GovernExclusion (created in #60) works with ConfigureGUI functionality (specifically MotionBuilderConfigOverlay).

Updates include:

  • Making MBItem._determine_name an abstract method so all the child classes can better handle their naming schema.
  • Simplify painting of the global mask canvas in MotionBuilderConfigOverlay.update_canvas
  • Update Shadow2DExclusion._paint_mask to handle triangles where all vertices lie on a line.
  • Remove govern exclusions from the configure combo box if a GovernExclusion is already defined.
  • GovernExclusions must regenerate their mask when updating the global mask since they [may] examine the global mask to build their own mask.

@rocco8773
use the motor signal movement_finished() to update the Axis control d…
ab38ef9 
…isplays
@rocco8773
disable configuration controls while the probe drive is moving
1151aa1
@rocco8773
if the status of one axis changes make the other AxisControlWidgets u…
4f2599f 
…pdate
@rocco8773
make the drive widget update its display when the configuration is ch…
cddf83b 
…anged
@rocco8773
fix over indent
d2bba71
@rocco8773
move all connected functions to MGWidget.configChanged into the _conf…
6caafb3 
…ig_changed_handler() method
@rocco8773
when _update_drive_control_widget() execute _refresh_drive_control() …
b186886 
…if the drive control widget does not have the valid MG
@rocco8773
Merge branch 'main' into gui_movement_modifications
b725894
@rocco8773
change default colors to be more color-blind friendly
0b3ba89
@rocco8773
Make sure MGWidget is seeded with a mg name if none is given, and the…
ed2a9e3 
… tooltip is accurately produced
@rocco8773
add tooltips for the MotionBuilder gear btn
66886a2
@rocco8773
do not false invalidate drive if we are editing an existing motion group
2ee22fd
@rocco8773
Merge branch 'main' into fix_configuregui_tooltips
37500a7
@rocco8773
Merge branch 'main' into configuregui_handle_governexclusion
fa4b033
@rocco8773
only compare dictionaries if mg_config is not None
174a310
@rocco8773
move all connected functionality to signal configChanged into method …
533b5d0 
…_config_changed_handler()
@rocco8773
GovernExclusions must regenerate their mask during a global mask update
dd8a794
@rocco8773
remove unused import
f4a7912
@rocco8773
make sure we do not index self.exclusions if no exclusion have been a…
9279489 
…dded to the list yet
@rocco8773
make MBItem._determine_name() an abstract method to children can bett…
24aa199 
…er handle their naming
@rocco8773
simplify plotting of global mask
87d0c2e
@rocco8773 rocco8773 added Component | GUI code touching the GUI functionality Componenet | Exclusion code touchign exclusion layer functionality Component | Motion Builder code touching the motion space/builder functionality labels Jan 15, 2025
@rocco8773 rocco8773 marked this pull request as ready for review January 15, 2025 03:38
@rocco8773 rocco8773 merged commit f894e38 into main Jan 15, 2025
8 checks passed
@rocco8773 rocco8773 deleted the configuregui_handle_governexclusion branch January 15, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Componenet | Exclusion code touchign exclusion layer functionality Component | GUI code touching the GUI functionality Component | Motion Builder code touching the motion space/builder functionality
Projects
BaPSF Motion
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rocco8773