feat: add kubebuilders validations for name length to be <= 63

.github/workflows/unit-integration-tests.yml

@@ -45,6 +45,10 @@ jobs:
       - name: Check out code into the Go module directory
         uses: actions/checkout@v4
 
+      - name: Set up Ginkgo CLI
+        run: |
+          go install github.com/onsi/ginkgo/v2/[email protected]
+
       - name: Run unit + integration tests & Generate coverage
         run: make test
 

Makefile

@@ -102,12 +102,17 @@ vet: ## Run go vet against code.
 ## --------------------------------------
 
 .PHONY: test
-test: manifests generate fmt vet local-unit-test
+test: manifests generate fmt vet local-unit-test integration-test
 
 .PHONY: local-unit-test
 local-unit-test: $(ENVTEST) ## Run tests.
 	CGO_ENABLED=1 KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" go test ./pkg/... -race -coverprofile=coverage.xml -covermode=atomic -v
 
+.PHONY: integration-test
+integration-test: $(ENVTEST) ## Run integration tests.
+	CGO_ENABLED=1 KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" \
+	ginkgo -v -p --race --cover --coverpkg=./... ./test/apis/...
+
 .PHONY: e2e-setup
 e2e-setup:
 	bash test/scripts/bootstrap.sh

api/v1alpha1/multiclusterservice_types.go

@@ -63,6 +63,7 @@ const (
 // +kubebuilder:printcolumn:JSONPath=`.metadata.creationTimestamp`,name="Age",type=date
 
 // MultiClusterService is the Schema for creating north-south L4 load balancer to consume services across clusters.
+// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 64",message="metadata.name max length is 63"
 type MultiClusterService struct {
 	metav1.TypeMeta `json:",inline"`
 	// +optional

api/v1alpha1/serviceexport_types.go

@@ -62,6 +62,7 @@ type ServiceExportStatus struct {
 // +kubebuilder:printcolumn:JSONPath=`.metadata.creationTimestamp`,name="Age",type=date
 
 // ServiceExport declares that the associated service should be exported to other clusters.
+// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 64",message="metadata.name max length is 63"
 type ServiceExport struct {
 	metav1.TypeMeta `json:",inline"`
 	// +optional

api/v1alpha1/serviceimport_types.go

@@ -16,6 +16,7 @@ import (
 // +kubebuilder:subresource:status
 
 // ServiceImport describes a service imported from clusters in a ClusterSet.
+// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 64",message="metadata.name max length is 63"
 type ServiceImport struct {
 	metav1.TypeMeta `json:",inline"`
 	// +optional

api/v1alpha1/trafficmanagerbackend_types.go

@@ -18,6 +18,7 @@ const (
 // A backend contains one or more endpoints. Therefore, the controller may create multiple endpoints under the Traffic
 // Manager Profile.
 // https://learn.microsoft.com/en-us/azure/traffic-manager/traffic-manager-endpoint-types
+// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 64",message="metadata.name max length is 63"
 type TrafficManagerBackend struct {
 	metav1.TypeMeta `json:",inline"`
 	// +optional

api/v1alpha1/trafficmanagerprofile_types.go

@@ -17,6 +17,7 @@ const (
 
 // TrafficManagerProfile is used to manage a simple Azure Traffic Manager Profile using cloud native way.
 // https://learn.microsoft.com/en-us/azure/traffic-manager/traffic-manager-overview
+// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 64",message="metadata.name max length is 63"
 type TrafficManagerProfile struct {
 	metav1.TypeMeta `json:",inline"`
 	// +optional

config/crd/bases/networking.fleet.azure.com_multiclusterservices.yaml

@@ -210,6 +210,9 @@ spec:
         required:
         - spec
         type: object
+        x-kubernetes-validations:
+        - message: metadata.name max length is 63
+          rule: size(self.metadata.name) < 64
     served: true
     storage: true
     subresources:

config/crd/bases/networking.fleet.azure.com_serviceexports.yaml

@@ -135,6 +135,9 @@ spec:
                 x-kubernetes-list-type: map
             type: object
         type: object
+        x-kubernetes-validations:
+        - message: metadata.name max length is 63
+          rule: size(self.metadata.name) < 64
     served: true
     storage: true
     subresources:

config/crd/bases/networking.fleet.azure.com_serviceimports.yaml

@@ -156,6 +156,9 @@ spec:
                 type: string
             type: object
         type: object
+        x-kubernetes-validations:
+        - message: metadata.name max length is 63
+          rule: size(self.metadata.name) < 64
     served: true
     storage: true
     subresources:

config/crd/bases/networking.fleet.azure.com_trafficmanagerbackends.yaml

@@ -221,6 +221,9 @@ spec:
         required:
         - spec
         type: object
+        x-kubernetes-validations:
+        - message: metadata.name max length is 63
+          rule: size(self.metadata.name) < 64
     served: true
     storage: true
     subresources:

config/crd/bases/networking.fleet.azure.com_trafficmanagerprofiles.yaml

@@ -191,6 +191,9 @@ spec:
         required:
         - spec
         type: object
+        x-kubernetes-validations:
+        - message: metadata.name max length is 63
+          rule: size(self.metadata.name) < 64
     served: true
     storage: true
     subresources: