feat: add kubebuilders validations for name length to be <= 63 #218

jamyct · 2024-11-15T12:32:05Z

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

run make reviewable for basic local test
Read and followed fleet-networking's Code of conduct.
uses conventional commit messages
includes documentation
adds unit tests

How has this code been tested

Special notes for your reviewer

codecov · 2024-11-15T12:42:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (78457e5) to head (8078722).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   79.79%   79.90%   +0.10%     
==========================================
  Files          27       27              
  Lines        3846     3846              
==========================================
+ Hits         3069     3073       +4     
+ Misses        622      618       -4     
  Partials      155      155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/rbac/role.yaml

test/apis/v1alpha1/api_validation_integration_test.go

doc

fix: requeue the request when the dns is not assigned

Bumps [thehanimo/pr-title-checker](https://github.com/thehanimo/pr-title-checker) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/thehanimo/pr-title-checker/releases) - [Commits](thehanimo/pr-title-checker@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: thehanimo/pr-title-checker dependency-type: direct:production update-type: version-update:semver-patch ...

zhiying-lin

Please apply the comments to all the APIs tests.

Makefile

test/apis/v1alpha1/api_validation_integration_test.go

test/apis/v1alpha1/suite_test.go

test/apis/v1alpha1/api_validation_integration_test.go

…source-validation pull latest

test/apis/v1alpha1/api_validation_integration_test.go

…abet spelling

jamyct · 2025-01-04T14:28:38Z

TODO:

Use table driven style to iterate through repeated cases/types to reduce code duplication
Consider removing tests unrelated to name size to simplify test file

zhiying-lin · 2025-01-06T02:16:45Z

For the TODO list,
1)the tests make sure it not only validates the length, but also checks whether it follows RFC 1035.

Please remove the commit messages when you merge the PR next time.
Otherwise, you will see this long commit messages.

jamyct changed the title ~~add kubebuilders validations for name length to be <= 63~~ feat: add kubebuilders validations for name length to be <= 63 Nov 15, 2024

jamyct added the enhancement New feature or request label Nov 20, 2024

jamyct added 6 commits November 20, 2024 13:05

add kubebuilders validations for name length to be <= 63

cabe958

add validation tests for member cluster service

d7110d4

delete e2e test file

72bcdd7

add tests for service export

cd5ab5f

add service import tests

8907ad1

add tests for service import and traffic manager profile/backend

c730655

jamyct force-pushed the add-resource-validation branch from a87267d to c730655 Compare November 20, 2024 02:13

jamyct added 13 commits November 20, 2024 17:09

add integration test to makefile

f5faf85

set TimeoutInSeconds default to 9

e6ac7e8

add conditions for MonitorConfig

5673aef

add message to rule

4f3a8df

add second values to monitorconfig

e2faf02

run goimports

f6c87ba

resolve type comparison issue in CEL

0630e47

add case fo when intervalInSeconds is not 30 or 10

a5d9fac

when IntervalInSeconds is 10, TimeoutInSeconds should be between 5 & 9

9023bdf

add integration-test to test

40ea19a

test all integration potential files

dccfcae

remove additional conditions

08f1c64

remove role.yaml changes

41ac502

zhiying-lin reviewed Dec 3, 2024

View reviewed changes

jamyct and others added 6 commits December 3, 2024 13:37

fix filepath in hubtestenv

50f4a8f

add copyright banner, fix format and change wording

679cdea

fix: fix the atm feature related bugs (Azure#220)

0217227

docs: add application migration tutorials (Azure#222)

e73a06d

doc

fix: requeue the request when the dns is not assigned (Azure#225)

b6652ae

fix: requeue the request when the dns is not assigned

jamyct added 4 commits December 12, 2024 17:46

fix context

e0211da

fix names of strings to test

bc21a2f

create global variable for nameWithInvalidSize

2c83da8

install ginkgo

c0acd83

zhiying-lin reviewed Dec 12, 2024

View reviewed changes

jamyct added 6 commits January 2, 2025 19:12

Merge branch 'main' of github.com:jamyct/fleet-networking into add-re…

fda9b28

…source-validation pull latest

create global name variables within integration test file

26533af

create global name variables for all remaining name types

5349a50

fix hubclient creation failure message and add deletiong failure message

c4a8a81

add hub client creation and deletion messages in integration test file

6ea313b

install ginkgoin .github/workflows/unit-integration-tests.yml

867e851

ryanzhang-oss reviewed Jan 3, 2025

View reviewed changes

test/apis/v1alpha1/api_validation_integration_test.go Outdated Show resolved Hide resolved

jamyct added 5 commits January 3, 2025 15:27

fix import styling in integration test file

7eb4c60

undo cluster to name change

e24440e

fix cluster access issue

fc9602c

fix member variable issue in traffic manager test

89b646c

install ginkgo before running tests

6fd0c47

ryanzhang-oss reviewed Jan 3, 2025

View reviewed changes

test/apis/v1alpha1/api_validation_integration_test.go Outdated Show resolved Hide resolved

test/apis/v1alpha1/api_validation_integration_test.go Show resolved Hide resolved

jamyct added 6 commits January 3, 2025 17:26

remove unnecessary extra lines

62f0c0d

declare var statusErr once and remove duplicate declarations

162de81

declare reused specs once and remove duplication

3311650

declare reused objectmeta once and remove duplications + correct alph…

5f6e7a3

…abet spelling

resolve conflict with lates commit

57efd4c

resolve conflict with latest commit

8078722

jamyct requested a review from ryanzhang-oss January 3, 2025 21:52

ryanzhang-oss approved these changes Jan 4, 2025

View reviewed changes

jamyct merged commit 1c36ce3 into Azure:main Jan 4, 2025
10 checks passed

jamyct deleted the add-resource-validation branch January 6, 2025 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add kubebuilders validations for name length to be <= 63 #218

feat: add kubebuilders validations for name length to be <= 63 #218

jamyct commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

zhiying-lin left a comment

jamyct commented Jan 4, 2025

zhiying-lin commented Jan 6, 2025

feat: add kubebuilders validations for name length to be <= 63 #218

feat: add kubebuilders validations for name length to be <= 63 #218

Conversation

jamyct commented Nov 15, 2024 • edited Loading

How has this code been tested

Special notes for your reviewer

codecov bot commented Nov 15, 2024 • edited Loading

Codecov Report

zhiying-lin left a comment

Choose a reason for hiding this comment

jamyct commented Jan 4, 2025

zhiying-lin commented Jan 6, 2025

jamyct commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading