-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DigitalTwin module - Merging originally splitted variants of child-modules into a single instance #4131
Draft
AlexanderSehr
wants to merge
35
commits into
main
Choose a base branch
from
users/alsehr/dtwinTest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
878cf65
Update to latest
AlexanderSehr d32cc82
Temp test changes
AlexanderSehr fa38e4b
Update to latest
AlexanderSehr 2e96bc3
Update to latest
AlexanderSehr 9f2702c
Update to latest
AlexanderSehr a6b4c4d
Update to latest
AlexanderSehr 6330be5
Update to latest
AlexanderSehr a8ca770
Added test confitinos
AlexanderSehr f6f8173
Update to latest
AlexanderSehr 4511711
Update to latest
AlexanderSehr b9fc79f
Update to latest
AlexanderSehr 46da0be
Update to latest
AlexanderSehr d96531c
Update to latest
AlexanderSehr d5458c8
Switched from service bus auth rule to topic auth rule
AlexanderSehr 175b3df
Update to latest
AlexanderSehr 4b1caf6
Update to latest
AlexanderSehr 20a1496
Update to latest
AlexanderSehr 28083ec
Simplification
AlexanderSehr 0b46624
Moved identity
AlexanderSehr 9373d46
Update to latest
AlexanderSehr b6e4c9a
Fixed var
AlexanderSehr 408fecd
Trimed slash
AlexanderSehr 4509c34
Added service bus param test
AlexanderSehr 3b3a7fc
Update to latest
AlexanderSehr cb648ce
Update to latest
AlexanderSehr b0b4709
Update to latest
AlexanderSehr 035a06c
Update to latest
AlexanderSehr 43961fb
Update to latest
AlexanderSehr 0d4c406
Alt implementation without references
AlexanderSehr 454bb42
Update to latest
AlexanderSehr 68b4ff5
Switched to test without PE
AlexanderSehr 199010b
Update to latest
AlexanderSehr 5702395
Merge branch 'main' into users/alsehr/dtwinTest
AlexanderSehr 2c1f512
Update to latest
AlexanderSehr b809bd6
Update to latest
AlexanderSehr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -211,7 +211,8 @@ runs: | |||||||
# Add custom parameters as needed | ||||||||
if($moduleTemplatePossibleParameters -contains 'resourceLocation') { | ||||||||
$functionInput.AdditionalParameters += @{ | ||||||||
resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | ||||||||
# resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | ||||||||
resourceLocation = 'eastus' | ||||||||
} | ||||||||
} | ||||||||
if($moduleTemplatePossibleParameters -contains 'baseTime') { | ||||||||
|
@@ -290,7 +291,8 @@ runs: | |||||||
|
||||||||
if($moduleTemplatePossibleParameters -contains 'resourceLocation') { | ||||||||
$functionInput.AdditionalParameters += @{ | ||||||||
resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | ||||||||
# resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | ||||||||
resourceLocation = 'eastus' | ||||||||
Comment on lines
+294
to
+295
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
once done with the PR... |
||||||||
} | ||||||||
} | ||||||||
if($moduleTemplatePossibleParameters -contains 'baseTime') { | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -82,7 +82,9 @@ jobs: | |||||||||
uses: ./.github/workflows/avm.template.module.yml | ||||||||||
with: | ||||||||||
workflowInput: "${{ needs.job_initialize_pipeline.outputs.workflowInput }}" | ||||||||||
moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}" | ||||||||||
# moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}" | ||||||||||
moduleTestFilePaths: "[{\"path\":\"tests/e2e/max/main.test.bicep\",\"name\":\"max\"}]" | ||||||||||
# moduleTestFilePaths: "[{\"path\":\"tests/e2e/testMe/main.test.bicep\",\"name\":\"testMe\"}]" | ||||||||||
Comment on lines
+85
to
+87
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
once done with the PR... |
||||||||||
psRuleModuleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.psRuleModuleTestFilePaths }}" | ||||||||||
modulePath: "${{ needs.job_initialize_pipeline.outputs.modulePath}}" | ||||||||||
secrets: inherit |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once done with the PR...