Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DigitalTwin module - Merging originally splitted variants of child-modules into a single instance #4131

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
878cf65
Update to latest
AlexanderSehr Jan 4, 2025
d32cc82
Temp test changes
AlexanderSehr Jan 4, 2025
fa38e4b
Update to latest
AlexanderSehr Jan 4, 2025
2e96bc3
Update to latest
AlexanderSehr Jan 4, 2025
9f2702c
Update to latest
AlexanderSehr Jan 4, 2025
a6b4c4d
Update to latest
AlexanderSehr Jan 4, 2025
6330be5
Update to latest
AlexanderSehr Jan 4, 2025
a8ca770
Added test confitinos
AlexanderSehr Jan 4, 2025
f6f8173
Update to latest
AlexanderSehr Jan 4, 2025
4511711
Update to latest
AlexanderSehr Jan 4, 2025
b9fc79f
Update to latest
AlexanderSehr Jan 4, 2025
46da0be
Update to latest
AlexanderSehr Jan 4, 2025
d96531c
Update to latest
AlexanderSehr Jan 4, 2025
d5458c8
Switched from service bus auth rule to topic auth rule
AlexanderSehr Jan 4, 2025
175b3df
Update to latest
AlexanderSehr Jan 4, 2025
4b1caf6
Update to latest
AlexanderSehr Jan 4, 2025
20a1496
Update to latest
AlexanderSehr Jan 4, 2025
28083ec
Simplification
AlexanderSehr Jan 4, 2025
0b46624
Moved identity
AlexanderSehr Jan 4, 2025
9373d46
Update to latest
AlexanderSehr Jan 4, 2025
b6e4c9a
Fixed var
AlexanderSehr Jan 4, 2025
408fecd
Trimed slash
AlexanderSehr Jan 4, 2025
4509c34
Added service bus param test
AlexanderSehr Jan 5, 2025
3b3a7fc
Update to latest
AlexanderSehr Jan 5, 2025
cb648ce
Update to latest
AlexanderSehr Jan 5, 2025
b0b4709
Update to latest
AlexanderSehr Jan 5, 2025
035a06c
Update to latest
AlexanderSehr Jan 5, 2025
43961fb
Update to latest
AlexanderSehr Jan 5, 2025
0d4c406
Alt implementation without references
AlexanderSehr Jan 5, 2025
454bb42
Update to latest
AlexanderSehr Jan 5, 2025
68b4ff5
Switched to test without PE
AlexanderSehr Jan 5, 2025
199010b
Update to latest
AlexanderSehr Jan 5, 2025
5702395
Merge branch 'main' into users/alsehr/dtwinTest
AlexanderSehr Jan 7, 2025
2c1f512
Update to latest
AlexanderSehr Jan 7, 2025
b809bd6
Update to latest
AlexanderSehr Jan 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ runs:
# Add custom parameters as needed
if($moduleTemplatePossibleParameters -contains 'resourceLocation') {
$functionInput.AdditionalParameters += @{
resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'
# resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'
resourceLocation = 'eastus'
Comment on lines +214 to +215
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'
resourceLocation = 'eastus'
resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'

once done with the PR...

}
}
if($moduleTemplatePossibleParameters -contains 'baseTime') {
Expand Down Expand Up @@ -290,7 +291,8 @@ runs:

if($moduleTemplatePossibleParameters -contains 'resourceLocation') {
$functionInput.AdditionalParameters += @{
resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'
# resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'
resourceLocation = 'eastus'
Comment on lines +294 to +295
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'
resourceLocation = 'eastus'
resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}'

once done with the PR...

}
}
if($moduleTemplatePossibleParameters -contains 'baseTime') {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ jobs:
uses: ./.github/workflows/avm.template.module.yml
with:
workflowInput: "${{ needs.job_initialize_pipeline.outputs.workflowInput }}"
moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}"
# moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}"
moduleTestFilePaths: "[{\"path\":\"tests/e2e/max/main.test.bicep\",\"name\":\"max\"}]"
# moduleTestFilePaths: "[{\"path\":\"tests/e2e/testMe/main.test.bicep\",\"name\":\"testMe\"}]"
Comment on lines +85 to +87
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}"
moduleTestFilePaths: "[{\"path\":\"tests/e2e/max/main.test.bicep\",\"name\":\"max\"}]"
# moduleTestFilePaths: "[{\"path\":\"tests/e2e/testMe/main.test.bicep\",\"name\":\"testMe\"}]"
moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}"

once done with the PR...

psRuleModuleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.psRuleModuleTestFilePaths }}"
modulePath: "${{ needs.job_initialize_pipeline.outputs.modulePath}}"
secrets: inherit
Loading
Loading