feat: DigitalTwin module - Merging originally splitted variants of child-modules into a single instance #4131
+3,439
−2,552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
added
Type: AVM 🅰️ ✌️ Ⓜ️
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
AlexanderSehr
commented
Jan 7, 2025
Comment on lines
+214
to
+215
| # resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | ||
| resourceLocation = 'eastus' |
There was a problem hiding this comment.
Suggested change
| # resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | |
| resourceLocation = 'eastus' | |
| resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' |
once done with the PR...
AlexanderSehr
commented
Jan 7, 2025
Comment on lines
+294
to
+295
| # resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | ||
| resourceLocation = 'eastus' |
There was a problem hiding this comment.
Suggested change
| # resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' | |
| resourceLocation = 'eastus' | |
| resourceLocation = '${{ steps.get-resource-location.outputs.resourceLocation }}' |
once done with the PR...
AlexanderSehr
commented
Jan 7, 2025
Comment on lines
+85
to
+87
| # moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}" | ||
| moduleTestFilePaths: "[{\"path\":\"tests/e2e/max/main.test.bicep\",\"name\":\"max\"}]" | ||
| # moduleTestFilePaths: "[{\"path\":\"tests/e2e/testMe/main.test.bicep\",\"name\":\"testMe\"}]" |
There was a problem hiding this comment.
Suggested change
| # moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}" | |
| moduleTestFilePaths: "[{\"path\":\"tests/e2e/max/main.test.bicep\",\"name\":\"max\"}]" | |
| # moduleTestFilePaths: "[{\"path\":\"tests/e2e/testMe/main.test.bicep\",\"name\":\"testMe\"}]" | |
| moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}" |
once done with the PR...
AlexanderSehr
commented
Jan 7, 2025
| @@ -428,7 +428,7 @@ function New-TemplateDeployment { | |||
| [switch] $DoNotThrow, | |||
|
|
|||
| [Parameter(Mandatory = $false)] | |||
| [int] $RetryLimit = 3, | |||
| [int] $RetryLimit = 1, | |||
There was a problem hiding this comment.
Suggested change
| [int] $RetryLimit = 1, | |
| [int] $RetryLimit = 3, |
once done with the PR...
AlexanderSehr
commented
Jan 7, 2025
There was a problem hiding this comment.
To be removed once PR is ready...
AlexanderSehr
commented
Jan 7, 2025
There was a problem hiding this comment.
To be removed or renamed (including metadata) once PR is done...
AlexanderSehr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
endpoint--event-gridendpoint--event-hubendpoint--service-busInto a single
endpointmodule making heavy use of UDTs & discriminatorsPipeline Reference
Type of Change
version.json:version.json.version.json.