-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes necessary for usage in earl #13
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ authors = [{ name = "Astera Institute", email = "[email protected]" }] | |
dependencies = [ | ||
"absl-py", | ||
"etils[epath,epy]", | ||
"jax", | ||
"jax>=0.4.36", | ||
"numpy", | ||
"packaging", | ||
"Pillow", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
from collections.abc import Mapping | ||
from typing import Any, Optional | ||
|
||
from .interface import Array, MetricWriter, Scalar | ||
|
||
|
||
class KeepLastWriter(MetricWriter): | ||
"""MetricWriter that keeps the last value for each metric in memory.""" | ||
|
||
def __init__(self, inner: MetricWriter): | ||
self._inner: MetricWriter = inner | ||
self.scalars: Optional[Mapping[str, Scalar]] = None | ||
self.images: Optional[Mapping[str, Array]] = None | ||
self.videos: Optional[Mapping[str, Array]] = None | ||
self.audios: Optional[Mapping[str, Array]] = None | ||
self.texts: Optional[Mapping[str, str]] = None | ||
self.hparams: Optional[Mapping[str, Any]] = None | ||
self.histogram_arrays: Optional[Mapping[str, Array]] = None | ||
self.histogram_num_buckets: Optional[Mapping[str, int]] = None | ||
|
||
def write_scalars(self, step: int, scalars: Mapping[str, Scalar]): | ||
self._inner.write_scalars(step, scalars) | ||
self.scalars = scalars | ||
|
||
def write_images(self, step: int, images: Mapping[str, Array]): | ||
self._inner.write_images(step, images) | ||
self.images = images | ||
|
||
def write_videos(self, step: int, videos: Mapping[str, Array]): | ||
self._inner.write_videos(step, videos) | ||
self.videos = videos | ||
|
||
def write_audios(self, step: int, audios: Mapping[str, Array], *, sample_rate: int): | ||
self._inner.write_audios(step, audios, sample_rate=sample_rate) | ||
self.audios = audios | ||
|
||
def write_texts(self, step: int, texts: Mapping[str, str]): | ||
self._inner.write_texts(step, texts) | ||
self.texts = texts | ||
|
||
def write_hparams(self, hparams: Mapping[str, Any]): | ||
self._inner.write_hparams(hparams) | ||
self.hparams = hparams | ||
|
||
def write_histograms( | ||
self, | ||
step: int, | ||
arrays: Mapping[str, Array], | ||
num_buckets: Optional[Mapping[str, int]] = None, | ||
): | ||
self._inner.write_histograms(step, arrays, num_buckets) | ||
self.histogram_arrays = arrays | ||
self.histogram_num_buckets = num_buckets |
77 changes: 77 additions & 0 deletions
77
src/jax_loop_utils/metric_writers/keep_last_writer_test.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
"""Tests for KeepLastMetricWriter.""" | ||
|
||
import numpy as np | ||
from absl.testing import absltest | ||
|
||
from jax_loop_utils.metric_writers import keep_last_writer, noop_writer | ||
|
||
|
||
class KeepLastWriterTest(absltest.TestCase): | ||
def setUp(self): | ||
super().setUp() | ||
self.writer = keep_last_writer.KeepLastWriter(noop_writer.NoOpWriter()) | ||
|
||
def test_write_scalars(self): | ||
scalars1 = {"metric1": 1.0} | ||
scalars2 = {"metric2": 2.0} | ||
|
||
self.writer.write_scalars(0, scalars1) | ||
self.assertEqual(self.writer.scalars, scalars1) | ||
|
||
self.writer.write_scalars(1, scalars2) | ||
self.assertEqual(self.writer.scalars, scalars2) | ||
|
||
def test_write_images(self): | ||
image = np.zeros((2, 2, 3)) | ||
images = {"image": image} | ||
|
||
self.writer.write_images(0, images) | ||
self.assertEqual(self.writer.images, images) | ||
|
||
def test_write_videos(self): | ||
video = np.zeros((10, 2, 2, 3)) | ||
videos = {"video": video} | ||
|
||
self.writer.write_videos(0, videos) | ||
self.assertEqual(self.writer.videos, videos) | ||
|
||
def test_write_audios(self): | ||
audio = np.zeros((100, 2)) | ||
audios = {"audio": audio} | ||
|
||
self.writer.write_audios(0, audios, sample_rate=44100) | ||
self.assertEqual(self.writer.audios, audios) | ||
|
||
def test_write_texts(self): | ||
texts = {"text": "hello world"} | ||
|
||
self.writer.write_texts(0, texts) | ||
self.assertEqual(self.writer.texts, texts) | ||
|
||
def test_write_hparams(self): | ||
hparams = {"learning_rate": 0.1} | ||
|
||
self.writer.write_hparams(hparams) | ||
self.assertEqual(self.writer.hparams, hparams) | ||
|
||
def test_write_histograms(self): | ||
arrays = {"hist": np.array([1, 2, 3])} | ||
num_buckets = {"hist": 10} | ||
|
||
self.writer.write_histograms(0, arrays, num_buckets) | ||
self.assertEqual(self.writer.histogram_arrays, arrays) | ||
self.assertEqual(self.writer.histogram_num_buckets, num_buckets) | ||
|
||
def test_initial_values_are_none(self): | ||
self.assertIsNone(self.writer.scalars) | ||
self.assertIsNone(self.writer.images) | ||
self.assertIsNone(self.writer.videos) | ||
self.assertIsNone(self.writer.audios) | ||
self.assertIsNone(self.writer.texts) | ||
self.assertIsNone(self.writer.hparams) | ||
self.assertIsNone(self.writer.histogram_arrays) | ||
self.assertIsNone(self.writer.histogram_num_buckets) | ||
|
||
|
||
if __name__ == "__main__": | ||
absltest.main() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
"""Writer that adds prefix and suffix to metric keys.""" | ||
|
||
from typing import Any, Mapping, Optional | ||
|
||
from jax_loop_utils.metric_writers import interface | ||
|
||
|
||
class PrefixSuffixWriter(interface.MetricWriter): | ||
"""Wraps a MetricWriter and adds prefix/suffix to all keys.""" | ||
|
||
def __init__( | ||
self, | ||
writer: interface.MetricWriter, | ||
prefix: str = "", | ||
suffix: str = "", | ||
): | ||
"""Initialize the writer. | ||
|
||
Args: | ||
writer: The underlying MetricWriter to wrap | ||
prefix: String to prepend to all keys | ||
suffix: String to append to all keys | ||
""" | ||
self._writer = writer | ||
self._prefix = prefix | ||
self._suffix = suffix | ||
|
||
def _transform_keys(self, data: Mapping[str, Any]) -> dict[str, Any]: | ||
"""Add prefix and suffix to all keys in the mapping.""" | ||
return { | ||
f"{self._prefix}{key}{self._suffix}": value for key, value in data.items() | ||
} | ||
mickvangelderen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
def write_scalars(self, step: int, scalars: Mapping[str, interface.Scalar]): | ||
self._writer.write_scalars(step, self._transform_keys(scalars)) | ||
|
||
def write_images(self, step: int, images: Mapping[str, interface.Array]): | ||
self._writer.write_images(step, self._transform_keys(images)) | ||
|
||
def write_videos(self, step: int, videos: Mapping[str, interface.Array]): | ||
self._writer.write_videos(step, self._transform_keys(videos)) | ||
|
||
def write_audios( | ||
self, step: int, audios: Mapping[str, interface.Array], *, sample_rate: int | ||
): | ||
self._writer.write_audios( | ||
step, self._transform_keys(audios), sample_rate=sample_rate | ||
) | ||
|
||
def write_texts(self, step: int, texts: Mapping[str, str]): | ||
self._writer.write_texts(step, self._transform_keys(texts)) | ||
|
||
def write_histograms( | ||
self, | ||
step: int, | ||
arrays: Mapping[str, interface.Array], | ||
num_buckets: Optional[Mapping[str, int]] = None, | ||
): | ||
if num_buckets is not None: | ||
num_buckets = self._transform_keys(num_buckets) | ||
self._writer.write_histograms(step, self._transform_keys(arrays), num_buckets) | ||
|
||
def write_hparams(self, hparams: Mapping[str, Any]): | ||
self._writer.write_hparams(self._transform_keys(hparams)) | ||
|
||
def flush(self): | ||
self._writer.flush() | ||
|
||
def close(self): | ||
self._writer.close() |
80 changes: 80 additions & 0 deletions
80
src/jax_loop_utils/metric_writers/prefix_suffix_writer_test.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
"""Tests for PrefixSuffixWriter.""" | ||
|
||
from unittest import mock | ||
|
||
import numpy as np | ||
from absl.testing import absltest | ||
|
||
from jax_loop_utils.metric_writers import memory_writer, prefix_suffix_writer | ||
|
||
|
||
class PrefixSuffixWriterTest(absltest.TestCase): | ||
def setUp(self): | ||
super().setUp() | ||
self.memory_writer = memory_writer.MemoryWriter() | ||
self.writer = prefix_suffix_writer.PrefixSuffixWriter( | ||
self.memory_writer, | ||
prefix="prefix/", | ||
suffix="/suffix", | ||
) | ||
|
||
def test_write_scalars(self): | ||
self.writer.write_scalars(0, {"metric": 1.0}) | ||
self.assertEqual(self.memory_writer.scalars, {0: {"prefix/metric/suffix": 1.0}}) | ||
|
||
def test_write_images(self): | ||
image = np.zeros((2, 2, 3)) | ||
self.writer.write_images(0, {"image": image}) | ||
self.assertEqual( | ||
list(self.memory_writer.images[0].keys()), ["prefix/image/suffix"] | ||
) | ||
|
||
def test_write_texts(self): | ||
self.writer.write_texts(0, {"text": "hello"}) | ||
self.assertEqual(self.memory_writer.texts, {0: {"prefix/text/suffix": "hello"}}) | ||
|
||
def test_write_histograms(self): | ||
data = np.array([1, 2, 3]) | ||
buckets = {"hist": 10} | ||
self.writer.write_histograms(0, {"hist": data}, buckets) | ||
self.assertEqual( | ||
list(self.memory_writer.histograms[0].arrays.keys()), | ||
["prefix/hist/suffix"], | ||
) | ||
|
||
def test_write_hparams(self): | ||
self.writer.write_hparams({"param": 1}) | ||
self.assertEqual(self.memory_writer.hparams, {"prefix/param/suffix": 1}) | ||
|
||
def test_empty_prefix_suffix(self): | ||
writer = prefix_suffix_writer.PrefixSuffixWriter(self.memory_writer) | ||
writer.write_scalars(0, {"metric": 1.0}) | ||
self.assertEqual(self.memory_writer.scalars, {0: {"metric": 1.0}}) | ||
|
||
def test_write_videos(self): | ||
video = np.zeros((10, 32, 32, 3)) # Simple video array with 10 frames | ||
self.writer.write_videos(0, {"video": video}) | ||
self.assertEqual( | ||
list(self.memory_writer.videos[0].keys()), ["prefix/video/suffix"] | ||
) | ||
|
||
def test_write_audios(self): | ||
audio = np.zeros((16000,)) # 1 second of audio at 16kHz | ||
self.writer.write_audios(0, {"audio": audio}, sample_rate=16000) | ||
self.assertEqual( | ||
list(self.memory_writer.audios[0].audios.keys()), ["prefix/audio/suffix"] | ||
) | ||
|
||
def test_close(self): | ||
with mock.patch.object(self.memory_writer, "close") as mock_close: | ||
self.writer.close() | ||
mock_close.assert_called_once() | ||
|
||
def test_flush(self): | ||
with mock.patch.object(self.memory_writer, "flush") as mock_flush: | ||
self.writer.flush() | ||
mock_flush.assert_called_once() | ||
|
||
|
||
if __name__ == "__main__": | ||
absltest.main() | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should assert prefix | suffix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user will get exactly what they asked for which will come at a small performance cost. I'd rather "define errors out of existence".