changes necessary for usage in earl #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required so that we can omit arguments to jax.tree_util.register_dataclass in memory_writer.py. Change-Id: I02056109268dba6470865ee678fa63e3427db416
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 93.18% 93.53% +0.35%
==========================================
Files 37 42 +5
Lines 2361 2554 +193
==========================================
+ Hits 2200 2389 +189
- Misses 161 165 +4 ☔ View full report in Codecov by Sentry. |
Change-Id: I972488484fc357afbd9e19dc3c4a1898e8698cd4
garymm
force-pushed
the
garymm/fixes
branch
2 times, most recently
from
547e630 to
d98c2c8
Compare
Change-Id: I2a6bf1d675b60d7862726f922c6f0c13836d0124
Change-Id: I146535ed4572b4e94769acdf843928ac1d6dab7b
DrJessop
reviewed
Dec 13, 2024
| writer: The underlying MetricWriter to wrap | ||
| prefix: String to prepend to all keys | ||
| suffix: String to append to all keys | ||
| """ |
There was a problem hiding this comment.
probably should assert prefix | suffix
There was a problem hiding this comment.
The user will get exactly what they asked for which will come at a small performance cost. I'd rather "define errors out of existence".
mickvangelderen
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I2a6bf1d675b60d7862726f922c6f0c13836d0124