Rework gear save to utilize get/setUnitLoadout #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoGuu
reviewed
Jun 21, 2019
Closed
DomT602
requested changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see no benefit in using a custom script to save gear manually when there are commands that can handle this, so here it is...
Resolves #562
Changes proposed in this pull request:
changed saving of player gear to utilize getUnitLoadout/setUnitLoadout which both reduces complexity of functions and should fix edge cases (see Weapon attachments don't save when you put the weapon in your backpack #562)
I have tested my changes and corrected any errors found
-> Testing will be done ASAP, don't have a machine rn