Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[half]Add ifdefs around usages of half #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[half]Add ifdefs around usages of half #6

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e8f8d2
[half]Add ifdefs around usages of half
sbalint98 Mar 22, 2021
2ff8f9f
:[cublas] correct typo, use ENABLE_HALF_ROUTINES instead of DISABLE
sbalint98 May 21, 2021
4aa199a
Removed unnecessary ifdefs and replaced half with cl::sycl::half
sbalint98 Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ static inline void gemm(cl::sycl::queue &queue, transpose transa, transpose tran
c, ldc);
gemm_postcondition(queue, transa, transb, m, n, k, alpha, a, lda, b, ldb, beta, c, ldc);
}

#ifdef ENABLE_HALF_ROUTINES
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to ifdef away this interface entirely? Could we just keep the interface and throw an exception if we detect that we want to run a half function on a device that does not support half (which currently is always in hipSYCL)? I think hipSYCL defines the half type to something like a short, so the interface by itself should compile.

static inline void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, std::int64_t m,
std::int64_t n, std::int64_t k, half alpha, cl::sycl::buffer<half, 1> &a,
std::int64_t lda, cl::sycl::buffer<half, 1> &b, std::int64_t ldb, half beta,
Expand All @@ -281,7 +281,7 @@ static inline void gemm(cl::sycl::queue &queue, transpose transa, transpose tran
c, ldc);
gemm_postcondition(queue, transa, transb, m, n, k, alpha, a, lda, b, ldb, beta, c, ldc);
}

#endif
static inline void gemm_batch(cl::sycl::queue &queue, transpose transa, transpose transb,
std::int64_t m, std::int64_t n, std::int64_t k, float alpha,
cl::sycl::buffer<float, 1> &a, std::int64_t lda,
Expand Down
1 change: 1 addition & 0 deletions include/oneapi/mkl/blas/detail/blas_ct_backends.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <cstdint>

#include "oneapi/mkl/types.hpp"
#include "oneapi/mkl/detail/config.hpp"
#include "oneapi/mkl/detail/backend_selector.hpp"

namespace oneapi {
Expand Down
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas/detail/blas_ct_backends.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ static inline void gemm(backend_selector<backend::BACKEND> selector, transpose t
std::int64_t lda, cl::sycl::buffer<std::complex<double>, 1> &b,
std::int64_t ldb, std::complex<double> beta,
cl::sycl::buffer<std::complex<double>, 1> &c, std::int64_t ldc);

#ifdef ENABLE_HALF_ROUTINES
static inline void gemm(backend_selector<backend::BACKEND> selector, transpose transa,
transpose transb, std::int64_t m, std::int64_t n, std::int64_t k,
half alpha, cl::sycl::buffer<half, 1> &a, std::int64_t lda,
Expand All @@ -425,7 +425,7 @@ static inline void gemm(backend_selector<backend::BACKEND> selector, transpose t
float alpha, cl::sycl::buffer<half, 1> &a, std::int64_t lda,
cl::sycl::buffer<half, 1> &b, std::int64_t ldb, float beta,
cl::sycl::buffer<float, 1> &c, std::int64_t ldc);

#endif
static inline void herk(backend_selector<backend::BACKEND> selector, uplo upper_lower,
transpose trans, std::int64_t n, std::int64_t k, float alpha,
cl::sycl::buffer<std::complex<float>, 1> &a, std::int64_t lda, float beta,
Expand Down
1 change: 1 addition & 0 deletions include/oneapi/mkl/blas/detail/blas_loader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <cstdint>
#include <CL/sycl.hpp>

#include "oneapi/mkl/detail/config.hpp"
#include "oneapi/mkl/types.hpp"

#include "oneapi/mkl/detail/export.hpp"
Expand Down
2 changes: 2 additions & 0 deletions include/oneapi/mkl/blas/detail/blas_loader.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ ONEMKL_EXPORT void gemm(oneapi::mkl::device libkey, cl::sycl::queue &queue, tran
std::int64_t lda, cl::sycl::buffer<std::complex<double>, 1> &b,
std::int64_t ldb, std::complex<double> beta,
cl::sycl::buffer<std::complex<double>, 1> &c, std::int64_t ldc);
#ifdef ENABLE_HALF_ROUTINES
ONEMKL_EXPORT void gemm(oneapi::mkl::device libkey, cl::sycl::queue &queue, transpose transa,
transpose transb, std::int64_t m, std::int64_t n, std::int64_t k,
half alpha, cl::sycl::buffer<half, 1> &a, std::int64_t lda,
Expand All @@ -406,6 +407,7 @@ ONEMKL_EXPORT void gemm(oneapi::mkl::device libkey, cl::sycl::queue &queue, tran
float alpha, cl::sycl::buffer<half, 1> &a, std::int64_t lda,
cl::sycl::buffer<half, 1> &b, std::int64_t ldb, float beta,
cl::sycl::buffer<float, 1> &c, std::int64_t ldc);
#endif

ONEMKL_EXPORT void syr2(oneapi::mkl::device libkey, cl::sycl::queue &queue, uplo upper_lower,
std::int64_t n, float alpha, cl::sycl::buffer<float, 1> &x,
Expand Down
1 change: 1 addition & 0 deletions include/oneapi/mkl/blas/detail/cublas/blas_ct.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

#include "oneapi/mkl/types.hpp"
#include "oneapi/mkl/detail/backend_selector.hpp"
#include "oneapi/mkl/detail/config.hpp"
#include "oneapi/mkl/blas/detail/cublas/onemkl_blas_cublas.hpp"
#include "oneapi/mkl/blas/detail/blas_ct_backends.hpp"

Expand Down
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas/detail/cublas/blas_ct.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ void gemm(backend_selector<backend::cublas> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#ifdef ENABLE_HALF_ROUTINES
void gemm(backend_selector<backend::cublas> selector, transpose transa, transpose transb,
std::int64_t m, std::int64_t n, std::int64_t k, half alpha, cl::sycl::buffer<half, 1> &a,
std::int64_t lda, cl::sycl::buffer<half, 1> &b, std::int64_t ldb, half beta,
Expand All @@ -767,7 +767,7 @@ void gemm(backend_selector<backend::cublas> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#endif
void syr2(backend_selector<backend::cublas> selector, uplo upper_lower, std::int64_t n, float alpha,
cl::sycl::buffer<float, 1> &x, std::int64_t incx, cl::sycl::buffer<float, 1> &y,
std::int64_t incy, cl::sycl::buffer<float, 1> &a, std::int64_t lda) {
Expand Down
1 change: 1 addition & 0 deletions include/oneapi/mkl/blas/detail/cublas/onemkl_blas_cublas.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <cstdint>
#include <string>
#include "oneapi/mkl/types.hpp"
#include "oneapi/mkl/detail/config.hpp"

namespace oneapi {
namespace mkl {
Expand Down
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas/detail/cublas/onemkl_blas_cublas.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, std::int64
cl::sycl::buffer<std::complex<double>, 1> &a, std::int64_t lda,
cl::sycl::buffer<std::complex<double>, 1> &b, std::int64_t ldb, std::complex<double> beta,
cl::sycl::buffer<std::complex<double>, 1> &c, std::int64_t ldc);

#ifdef ENABLE_HALF_ROUTINES
void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, std::int64_t m,
std::int64_t n, std::int64_t k, half alpha, cl::sycl::buffer<half, 1> &a,
std::int64_t lda, cl::sycl::buffer<half, 1> &b, std::int64_t ldb, half beta,
Expand All @@ -506,7 +506,7 @@ void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, std::int64
std::int64_t n, std::int64_t k, float alpha, cl::sycl::buffer<half, 1> &a,
std::int64_t lda, cl::sycl::buffer<half, 1> &b, std::int64_t ldb, float beta,
cl::sycl::buffer<float, 1> &c, std::int64_t ldc);

#endif
void hemm(cl::sycl::queue &queue, side left_right, uplo upper_lower, std::int64_t m, std::int64_t n,
std::complex<float> alpha, cl::sycl::buffer<std::complex<float>, 1> &a, std::int64_t lda,
cl::sycl::buffer<std::complex<float>, 1> &b, std::int64_t ldb, std::complex<float> beta,
Expand Down
1 change: 1 addition & 0 deletions include/oneapi/mkl/blas/detail/mklcpu/blas_ct.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <cstdint>

#include "oneapi/mkl/types.hpp"
#include "oneapi/mkl/detail/config.hpp"
#include "oneapi/mkl/detail/backend_selector.hpp"

#include "oneapi/mkl/blas/detail/blas_ct_backends.hpp"
Expand Down
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas/detail/mklcpu/blas_ct.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ void gemm(backend_selector<backend::mklcpu> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#ifdef ENABLE_HALF_ROUTINES
void gemm(backend_selector<backend::mklcpu> selector, transpose transa, transpose transb,
std::int64_t m, std::int64_t n, std::int64_t k, half alpha, cl::sycl::buffer<half, 1> &a,
std::int64_t lda, cl::sycl::buffer<half, 1> &b, std::int64_t ldb, half beta,
Expand All @@ -767,7 +767,7 @@ void gemm(backend_selector<backend::mklcpu> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#endif
void syr2(backend_selector<backend::mklcpu> selector, uplo upper_lower, std::int64_t n, float alpha,
cl::sycl::buffer<float, 1> &x, std::int64_t incx, cl::sycl::buffer<float, 1> &y,
std::int64_t incy, cl::sycl::buffer<float, 1> &a, std::int64_t lda) {
Expand Down
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas/detail/mklgpu/blas_ct.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ void gemm(backend_selector<backend::mklgpu> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#ifdef ENABLE_HALF_ROUTINES
void gemm(backend_selector<backend::mklgpu> selector, transpose transa, transpose transb,
std::int64_t m, std::int64_t n, std::int64_t k, half alpha, cl::sycl::buffer<half, 1> &a,
std::int64_t lda, cl::sycl::buffer<half, 1> &b, std::int64_t ldb, half beta,
Expand All @@ -767,7 +767,7 @@ void gemm(backend_selector<backend::mklgpu> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#endif
void syr2(backend_selector<backend::mklgpu> selector, uplo upper_lower, std::int64_t n, float alpha,
cl::sycl::buffer<float, 1> &x, std::int64_t incx, cl::sycl::buffer<float, 1> &y,
std::int64_t incy, cl::sycl::buffer<float, 1> &a, std::int64_t lda) {
Expand Down
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas/detail/netlib/blas_ct.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ void gemm(backend_selector<backend::netlib> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#ifdef ENABLE_HALF_ROUTINES
void gemm(backend_selector<backend::netlib> selector, transpose transa, transpose transb,
std::int64_t m, std::int64_t n, std::int64_t k, half alpha, cl::sycl::buffer<half, 1> &a,
std::int64_t lda, cl::sycl::buffer<half, 1> &b, std::int64_t ldb, half beta,
Expand All @@ -767,7 +767,7 @@ void gemm(backend_selector<backend::netlib> selector, transpose transa, transpos
gemm_postcondition(selector.get_queue(), transa, transb, m, n, k, alpha, a, lda, b, ldb, beta,
c, ldc);
}

#endif
void syr2(backend_selector<backend::netlib> selector, uplo upper_lower, std::int64_t n, float alpha,
cl::sycl::buffer<float, 1> &x, std::int64_t incx, cl::sycl::buffer<float, 1> &y,
std::int64_t incy, cl::sycl::buffer<float, 1> &a, std::int64_t lda) {
Expand Down
4 changes: 2 additions & 2 deletions include/oneapi/mkl/blas/detail/onemkl_blas_backends.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ ONEMKL_EXPORT void gemm(cl::sycl::queue &queue, oneapi::mkl::transpose transa,
cl::sycl::buffer<std::complex<double>, 1> &b, std::int64_t ldb,
std::complex<double> beta, cl::sycl::buffer<std::complex<double>, 1> &c,
std::int64_t ldc);

#ifdef ENABLE_HALF_ROUTINES
ONEMKL_EXPORT void gemm(cl::sycl::queue &queue, oneapi::mkl::transpose transa,
oneapi::mkl::transpose transb, std::int64_t m, std::int64_t n,
std::int64_t k, half alpha, cl::sycl::buffer<half, 1> &a, std::int64_t lda,
Expand All @@ -58,7 +58,7 @@ ONEMKL_EXPORT void gemm(cl::sycl::queue &queue, oneapi::mkl::transpose transa,
std::int64_t k, float alpha, cl::sycl::buffer<half, 1> &a, std::int64_t lda,
cl::sycl::buffer<half, 1> &b, std::int64_t ldb, float beta,
cl::sycl::buffer<float, 1> &c, std::int64_t ldc);

#endif
ONEMKL_EXPORT void symm(cl::sycl::queue &queue, oneapi::mkl::side left_right,
oneapi::mkl::uplo upper_lower, std::int64_t m, std::int64_t n, float alpha,
cl::sycl::buffer<float, 1> &a, std::int64_t lda,
Expand Down
1 change: 1 addition & 0 deletions include/oneapi/mkl/blas/predicates.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

#include "oneapi/mkl/exceptions.hpp"
#include "oneapi/mkl/types.hpp"
#include "oneapi/mkl/detail/config.hpp"

namespace oneapi {
namespace mkl {
Expand Down
7 changes: 4 additions & 3 deletions include/oneapi/mkl/blas/predicates.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1518,6 +1518,7 @@ inline void gemm_postcondition(cl::sycl::queue &queue, transpose transa, transpo
#endif
}

#ifdef ENABLE_HALF_ROUTINES
inline void gemm_precondition(cl::sycl::queue &queue, transpose transa, transpose transb,
std::int64_t m, std::int64_t n, std::int64_t k, half alpha,
cl::sycl::buffer<half, 1> &a, std::int64_t lda,
Expand Down Expand Up @@ -1557,7 +1558,7 @@ inline void gemm_postcondition(cl::sycl::queue &queue, transpose transa, transpo
/* add postchecks to queue here for input args. */
#endif
}

#endif
inline void syr2_precondition(cl::sycl::queue &queue, uplo upper_lower, std::int64_t n, float alpha,
cl::sycl::buffer<float, 1> &x, std::int64_t incx,
cl::sycl::buffer<float, 1> &y, std::int64_t incy,
Expand Down Expand Up @@ -4749,7 +4750,7 @@ inline void gemm_postcondition(cl::sycl::queue &queue, transpose transa, transpo
/* add postchecks to queue here for input args. */
#endif
}

#ifdef ENABLE_HALF_ROUTINES
inline void gemm_precondition(cl::sycl::queue &queue, transpose transa, transpose transb,
std::int64_t m, std::int64_t n, std::int64_t k, half alpha,
const half *a, std::int64_t lda, const half *b, std::int64_t ldb,
Expand All @@ -4769,7 +4770,7 @@ inline void gemm_postcondition(cl::sycl::queue &queue, transpose transa, transpo
/* add postchecks to queue here for input args. */
#endif
}

#endif
inline void syr2_precondition(cl::sycl::queue &queue, uplo upper_lower, std::int64_t n, float alpha,
const float *x, std::int64_t incx, const float *y, std::int64_t incy,
float *a, std::int64_t lda,
Expand Down
2 changes: 2 additions & 0 deletions include/oneapi/mkl/detail/backend_selector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
namespace oneapi {
namespace mkl {

using namespace cl;

template <backend Backend>
class backend_selector {
public:
Expand Down
16 changes: 8 additions & 8 deletions src/blas/backends/cublas/cublas_level3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ inline void gemm(Func func, DATATYPE_A DT_A, DATATYPE_B DT_B, DATATYPE_C DT_C,
gemm(CUBLAS_ROUTINE, CUDADATATYPE_A, CUDADATATYPE_B, CUDADATATYPE_C, queue, transa, \
transb, m, n, k, alpha, a, lda, b, ldb, beta, c, ldc); \
}

#ifdef ENABLE_HALF_ROUTINES
GEMM_EX_LAUNCHER(half, half, float, cublasGemmEx, CUDA_R_16F, CUDA_R_16F, CUDA_R_32F)
GEMM_EX_LAUNCHER(half, half, half, cublasGemmEx, CUDA_R_16F, CUDA_R_16F, CUDA_R_16F)

#endif
#undef GEMM_EX_LAUNCHER

template <typename Func, typename T>
Expand Down Expand Up @@ -465,14 +465,14 @@ GEMM_LAUNCHER_USM(std::complex<float>, cublasCgemm)
GEMM_LAUNCHER_USM(std::complex<double>, cublasZgemm)

#undef GEMM_LAUNCHER_USM

#ifdef ENABLE_HALF_ROUTINES
cl::sycl::event gemm(cl::sycl::queue &queue, transpose transa, transpose transb, std::int64_t m,
std::int64_t n, std::int64_t k, half alpha, const half *a, std::int64_t lda,
const half *b, std::int64_t ldb, half beta, half *c, std::int64_t ldc,
const cl::sycl::vector_class<cl::sycl::event> &dependencies) {
throw unimplemented("blas", "gemm", "for column_major layout");
}

#endif
template <typename Func, typename T>
inline cl::sycl::event symm(Func func, cl::sycl::queue &queue, side left_right, uplo upper_lower,
int64_t m, int64_t n, T alpha, const T *a, int64_t lda, const T *b,
Expand Down Expand Up @@ -860,10 +860,10 @@ inline void gemm(Func func, DATATYPE_A DT_A, DATATYPE_B DT_B, DATATYPE_C DT_C,
gemm(CUBLAS_ROUTINE, CUDADATATYPE_A, CUDADATATYPE_B, CUDADATATYPE_C, queue, transa, \
transb, m, n, k, alpha, a, lda, b, ldb, beta, c, ldc); \
}

#ifdef ENABLE_HALF_ROUTINES
GEMM_EX_LAUNCHER(half, half, float, cublasGemmEx, CUDA_R_16F, CUDA_R_16F, CUDA_R_32F)
GEMM_EX_LAUNCHER(half, half, half, cublasGemmEx, CUDA_R_16F, CUDA_R_16F, CUDA_R_16F)

#endif
#undef GEMM_EX_LAUNCHER

template <typename Func, typename T>
Expand Down Expand Up @@ -1065,14 +1065,14 @@ GEMM_LAUNCHER_USM(std::complex<float>, cublasCgemm)
GEMM_LAUNCHER_USM(std::complex<double>, cublasZgemm)

#undef GEMM_LAUNCHER_USM

#ifdef ENABLE_HALF_ROUTINES
cl::sycl::event gemm(cl::sycl::queue &queue, transpose transa, transpose transb, std::int64_t m,
std::int64_t n, std::int64_t k, half alpha, const half *a, std::int64_t lda,
const half *b, std::int64_t ldb, half beta, half *c, std::int64_t ldc,
const cl::sycl::vector_class<cl::sycl::event> &dependencies) {
throw unimplemented("blas", "gemm", "for row_major layout");
}

#endif
template <typename Func, typename T>
inline cl::sycl::event symm(Func func, cl::sycl::queue &queue, side left_right, uplo upper_lower,
int64_t m, int64_t n, T alpha, const T *a, int64_t lda, const T *b,
Expand Down
4 changes: 4 additions & 0 deletions src/blas/backends/cublas/mkl_blas_cublas_wrappers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ extern "C" blas_function_table_t mkl_blas_table = {
oneapi::mkl::blas::cublas::column_major::gemm,
oneapi::mkl::blas::cublas::column_major::gemm,
oneapi::mkl::blas::cublas::column_major::gemm,
#ifdef ENABLE_HALF_ROUTINES
oneapi::mkl::blas::cublas::column_major::gemm,
oneapi::mkl::blas::cublas::column_major::gemm,
#endif
oneapi::mkl::blas::cublas::column_major::hemm,
oneapi::mkl::blas::cublas::column_major::hemm,
oneapi::mkl::blas::cublas::column_major::herk,
Expand Down Expand Up @@ -478,8 +480,10 @@ extern "C" blas_function_table_t mkl_blas_table = {
oneapi::mkl::blas::cublas::row_major::gemm,
oneapi::mkl::blas::cublas::row_major::gemm,
oneapi::mkl::blas::cublas::row_major::gemm,
#ifdef ENABLE_HALF_ROUTINES
oneapi::mkl::blas::cublas::row_major::gemm,
oneapi::mkl::blas::cublas::row_major::gemm,
#endif
oneapi::mkl::blas::cublas::row_major::hemm,
oneapi::mkl::blas::cublas::row_major::hemm,
oneapi::mkl::blas::cublas::row_major::herk,
Expand Down
5 changes: 2 additions & 3 deletions src/blas/backends/mklcpu/mklcpu_level3.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, int64_t m,
});
});
}

#ifdef ENABLE_HALF_ROUTINES
void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, int64_t m, int64_t n,
int64_t k, half alpha, cl::sycl::buffer<half, 1> &a, int64_t lda,
cl::sycl::buffer<half, 1> &b, int64_t ldb, half beta, cl::sycl::buffer<half, 1> &c,
Expand Down Expand Up @@ -140,7 +140,6 @@ void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, int64_t m,
});
});
}

void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, int64_t m, int64_t n,
int64_t k, float alpha, cl::sycl::buffer<half, 1> &a, int64_t lda,
cl::sycl::buffer<half, 1> &b, int64_t ldb, float beta, cl::sycl::buffer<float, 1> &c,
Expand Down Expand Up @@ -173,7 +172,7 @@ void gemm(cl::sycl::queue &queue, transpose transa, transpose transb, int64_t m,
});
});
}

#endif
void hemm(cl::sycl::queue &queue, side left_right, uplo upper_lower, int64_t m, int64_t n,
std::complex<float> alpha, cl::sycl::buffer<std::complex<float>, 1> &a, int64_t lda,
cl::sycl::buffer<std::complex<float>, 1> &b, int64_t ldb, std::complex<float> beta,
Expand Down
4 changes: 4 additions & 0 deletions src/blas/backends/mklcpu/mklcpu_wrappers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,10 @@ extern "C" ONEMKL_EXPORT blas_function_table_t mkl_blas_table = {
oneapi::mkl::blas::mklcpu::column_major::gemm,
oneapi::mkl::blas::mklcpu::column_major::gemm,
oneapi::mkl::blas::mklcpu::column_major::gemm,
#ifdef ENABLE_HALF_ROUTINES
oneapi::mkl::blas::mklcpu::column_major::gemm,
oneapi::mkl::blas::mklcpu::column_major::gemm,
#endif
oneapi::mkl::blas::mklcpu::column_major::hemm,
oneapi::mkl::blas::mklcpu::column_major::hemm,
oneapi::mkl::blas::mklcpu::column_major::herk,
Expand Down Expand Up @@ -479,8 +481,10 @@ extern "C" ONEMKL_EXPORT blas_function_table_t mkl_blas_table = {
oneapi::mkl::blas::mklcpu::row_major::gemm,
oneapi::mkl::blas::mklcpu::row_major::gemm,
oneapi::mkl::blas::mklcpu::row_major::gemm,
#ifdef ENABLE_HALF_ROUTINES
oneapi::mkl::blas::mklcpu::row_major::gemm,
oneapi::mkl::blas::mklcpu::row_major::gemm,
#endif
oneapi::mkl::blas::mklcpu::row_major::hemm,
oneapi::mkl::blas::mklcpu::row_major::hemm,
oneapi::mkl::blas::mklcpu::row_major::herk,
Expand Down
Loading