[half]Add ifdefs around usages of half #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbalint98
force-pushed
the
half
branch
4 times, most recently
from
146b9e2 to
f9a3289
Compare
Use DISABLE_HALF_RUTINES, use cmake config to set
fodinabor
reviewed
May 21, 2021
src/config.hpp.in
Outdated
| @@ -25,6 +25,7 @@ | |||
| #cmakedefine ENABLE_MKLCPU_BACKEND | |||
| #cmakedefine ENABLE_MKLGPU_BACKEND | |||
| #cmakedefine ENABLE_NETLIB_BACKEND | |||
| #cmakedefine DISABLE_HALF_RUTINES | |||
There was a problem hiding this comment.
typo: routines and also I'm not really a fan of disabling stuff... can we make this a ENABLE.. and default to ON or isn't it possible to default something in this weird file? :)
illuhad
reviewed
May 22, 2021
include/oneapi/mkl/blas.hxx
Outdated
| @@ -261,7 +261,7 @@ static inline void gemm(cl::sycl::queue &queue, transpose transa, transpose tran | |||
| c, ldc); | |||
| gemm_postcondition(queue, transa, transb, m, n, k, alpha, a, lda, b, ldb, beta, c, ldc); | |||
| } | |||
|
|
|||
| #ifdef ENABLE_HALF_ROUTINES | |||
There was a problem hiding this comment.
Do we even need to ifdef away this interface entirely? Could we just keep the interface and throw an exception if we detect that we want to run a half function on a device that does not support half (which currently is always in hipSYCL)? I think hipSYCL defines the half type to something like a short, so the interface by itself should compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in hipSYCL half is not implemented yet therefore we need to disable the functions that use it