Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only assert if go package is present if generating go types #211

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Only assert if go package is present if generating go types #211

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f53e48
only assert go package if generating go types
MOmarMiraj Nov 18, 2024
ba9417d
fmt fix
MOmarMiraj Nov 18, 2024
0a879c5
properly check if the language is golang
MOmarMiraj Nov 18, 2024
d142e63
fix import error
MOmarMiraj Nov 18, 2024
c3596bb
fix import error
MOmarMiraj Nov 18, 2024
3d67aae
condense the go feature block
MOmarMiraj Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,10 @@ fn override_configuration(mut config: Config, options: &Args) -> anyhow::Result<
if let Some(go_package) = options.go_package.as_ref() {
config.go.package = go_package.to_string();
}
assert_go_package_present(&config)?;

if let Some(args::AvailableLanguage::Go) = options.language {
assert_go_package_present(&config)?;
}
darrell-roberts marked this conversation as resolved.
Show resolved Hide resolved
}

config.target_os = options.target_os.as_deref().unwrap_or_default().to_vec();
Expand Down
Loading