Only assert if go package is present if generating go types #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As apart of !184 there has been a regression as if you build typeshare with all features and are typesharing not in Golang, the
assert_go_package_is_present
function will still be ran even though your generating for another languageUpdated the code to only run the function if the language of the types being converted is Golang.
To test:
Download the latest
typeshare-cli
from main and try generating types for any language but Go without a--go-package
in the cmd and a package in thetypeshare.toml
.Should error out with:Try the same thing but install from my branch like so:
and should work as expected.