Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking/pof tiebreaker #290

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
46087b5
[testsuites] isolate Move policy upgrade testing, make backwards comp…
0o-de-lally Jul 16, 2024
3dbf698
[testsuite] isolating CI Move upgrade testing (#289)
0o-de-lally Jul 17, 2024
9ba97a0
feat multi action offer - WIP
soaresa Jun 12, 2024
7846aad
set error codes for offer functions
soaresa Jun 12, 2024
3c6b191
adds more tests to multi action offer
soaresa Jun 13, 2024
e9892ff
applies canonical errors to offer functions, and creates more tests
soaresa Jun 13, 2024
dffd5da
supports submit new offers, and adds more tests
soaresa Jun 13, 2024
852e7b4
applies new offer flow to the other tests
soaresa Jun 13, 2024
beb8e4b
adds offer flow to new authorities voted
soaresa Jun 13, 2024
6c4955f
creates multisign signer to offer authorities triggered by vote, and …
soaresa Jun 14, 2024
e3f0a3e
add test finalize multisign account having a pending claim
soaresa Jun 14, 2024
d729c98
adds migration to init offer, and never drop the offer
soaresa Jun 14, 2024
38a1bf3
adds test for expired offer
soaresa Jun 14, 2024
b84ecd1
cleans proposed list only when offer is expired
soaresa Jun 14, 2024
eddd10a
adds support for epoch expiration per authority
soaresa Jun 17, 2024
2f38b78
fixes adding to offer authorities voted in different votes before claims
soaresa Jun 17, 2024
1750102
clean up
soaresa Jun 17, 2024
80f52a5
set max number of offer addresses to avoid DoS
soaresa Jun 17, 2024
0d5e57d
test default value of epochs to expire
soaresa Jun 17, 2024
ffe0f7c
ensure proposed list is distinct addresses and without owner
soaresa Jun 17, 2024
28bb4fa
adds tests for offer migration
soaresa Jun 17, 2024
e760ce2
ensures gov proposes cannot have invalid, duplicated and owner address
soaresa Jun 17, 2024
587146d
adds new constraints and tests to multi_action governance
soaresa Jun 17, 2024
0104e95
refactoring
soaresa Jun 17, 2024
78bd05b
fixes indentation
soaresa Jun 17, 2024
a26f753
creates module multi_action_migration - WIP
soaresa Jun 17, 2024
7d3ddd8
converts error codes to decimal notation
soaresa Jun 18, 2024
6455c70
sets expire epoch to use offer migration
soaresa Jun 18, 2024
621dbbb
converts exist_offer into a view function
soaresa Jun 18, 2024
d54965a
comments code not used and not tested
soaresa Jun 18, 2024
0162fec
fixes indentation
soaresa Jun 18, 2024
746718f
adds test try to vote twice on the same ballot
soaresa Jun 18, 2024
96e0bd9
applies offer flows to safe, community wallet and donor voice - WIP
soaresa Jun 18, 2024
c697c08
adds propose_offer call to init_payment_multisig
soaresa Jun 18, 2024
9981fca
fix scenarios
soaresa Jun 18, 2024
c74f148
removes multi_action deprecated finaliza_and_cage version
soaresa Jun 18, 2024
bc249c1
break down the update_offer function into 4 smaller functions
soaresa Jun 18, 2024
e62e07a
propagate n_of_m voted to change after last offer claim
soaresa Jun 19, 2024
228ff50
add test two_simultaneous_governance_vote + clean up code
soaresa Jun 19, 2024
868e980
ensure that offer n_of_m will be cleaned after a change of n_of_m
soaresa Jun 19, 2024
a5220de
set multi_action propose_offer not a transaction
soaresa Jun 20, 2024
5a8f673
implementing first smoke test to create community wallet with offer/c…
soaresa Jun 21, 2024
61a7366
community wallet cli test refactoring
soaresa Jun 21, 2024
d4eadfd
prints a message after txs completed and update test comments
soaresa Jun 21, 2024
681b9f0
adds propose_offer cli and smoke test update_community_wallet_offer
soaresa Jun 21, 2024
efc904c
create test vote new signer to cw + migrate cw tests to community_wal…
soaresa Jun 21, 2024
a0a0f1e
fix threshold bug to remove admin from cw + add test to vote removal …
soaresa Jun 21, 2024
ea0bef2
cargo fmt && cargo clippy
soaresa Jun 21, 2024
d545f13
improves cw tests, fix a threshold bug, duplicated error codes, and e…
soaresa Jun 24, 2024
7f24ea0
adds CLI and smoke test for offer migration
soaresa Jun 24, 2024
74c843d
fix threshold check to reduce cw admins
soaresa Jun 24, 2024
9f1e842
adds offer migration test with twin db
soaresa Jul 3, 2024
6fea329
applies fmt --all
soaresa Jul 3, 2024
9d73337
fixes linting errors
soaresa Jul 4, 2024
66db030
updates a constant name
soaresa Jul 8, 2024
477b9ac
lint fixes
soaresa Jul 10, 2024
644eafe
lint fixes for libra framework sdk builder
soaresa Jul 10, 2024
e13b4aa
shuffles validators with same bid value
soaresa Jul 10, 2024
9953fec
reduces val set for competition between qualified bidders having 21 o…
soaresa Jul 12, 2024
a263af4
initializes randomness on ol_reconfigure_for_test
soaresa Jul 12, 2024
2c2b827
refactors musical chairs mod and adds more tests
soaresa Jul 12, 2024
d56cfe8
gitignore target folders, and move coverage files
soaresa Jul 12, 2024
f726412
fixes reward thermostat call order - WIP
soaresa Jul 16, 2024
3265bd4
fix budget to collect, and fee calculus
soaresa Jul 17, 2024
a42ca78
test subsidy and rewards having a non compliant val
soaresa Jul 17, 2024
11647e9
test that entry fee sum is burnt on epoch trigger
soaresa Jul 18, 2024
89e9c87
adds tests to reward_thermostat increasing and decreasing rewards
soaresa Jul 18, 2024
b5a01fe
extracts pure function from reward_thermostat and adds tests
soaresa Jul 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,18 @@ rustflags = ["--cfg", "tokio_unstable", "-C", "force-frame-pointers=yes", "-C",

# TODO(grao): Figure out whether we should enable other cpu features, and whether we should use a different way to configure them rather than list every single one here.
[target.x86_64-unknown-linux-gnu]
rustflags = ["--cfg", "tokio_unstable", "-C", "link-arg=-fuse-ld=lld", "-C", "force-frame-pointers=yes", "-C", "force-unwind-tables=yes", "-C", "target-feature=+sse4.2"]
rustflags = [
"--cfg",
"tokio_unstable",
"-C",
"link-arg=-fuse-ld=lld",
"-C",
"force-frame-pointers=yes",
"-C",
"force-unwind-tables=yes",
"-C",
"target-feature=+sse4.2",
]

# 64 bit MSVC
[target.x86_64-pc-windows-msvc]
Expand All @@ -27,5 +38,11 @@ rustflags = [
"-C",
"force-unwind-tables=yes",
"-C",
"link-arg=/STACK:8000000" # Set stack to 8 MB
]
"link-arg=/STACK:8000000", # Set stack to 8 MB
]

[target.aarch64-apple-darwin]
rustflags = [
"-C",
"link-arg=-L/opt/homebrew/opt/gmp",
]
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
- "release**"
- "main**"
schedule:
- cron: '30 00 * * *'
- cron: "30 00 * * *"

env:
DIEM_FORGE_NODE_BIN_PATH: ${{github.workspace}}/diem-node
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:

- name: upgrade - should be backwards compatible
# should always run unless we explicitly mark the branch or tag as "breaking"
if: ${{ ! contains(github.ref_name, 'breaking/') }}
if: not(contains(${{github.ref_name}}, "breaking/"))
working-directory: ./upgrade-tests
# NOTE: upgrade tests which compile Move code, and then submit in the same thread will cause a stack overflow with the default rust stack size.
run: RUST_MIN_STACK=104857600 cargo test compatible_
Expand Down
8 changes: 6 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Generated by Cargo
# will have compiled files and executables
/target/
**/target/

# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Expand All @@ -24,4 +24,8 @@ sccache.log
*.bpl

# exclude diem dependency
diem/
diem/

# exclude move coverage
.coverage_map.mvcov
.trace
Loading
Loading