Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking/pof tiebreaker #290

Closed
wants to merge 68 commits into from
Closed

Breaking/pof tiebreaker #290

wants to merge 68 commits into from

Conversation

soaresa
Copy link
Contributor

@soaresa soaresa commented Jul 18, 2024 •
edited
Loading

Test Coverage Overall Score #Tests
Before 68.64 303
After 70.07 330
Diff. 2% 27

0o-de-lally and others added 30 commits July 19, 2024 09:47
@0o-de-lally @soaresa
[testsuites] isolate Move policy upgrade testing, make backwards comp…
46087b5 
…at test optional (0LNetworkCommunity#286)
@0o-de-lally @soaresa
[testsuite] isolating CI Move upgrade testing (0LNetworkCommunity#289)
3dbf698
@soaresa
feat multi action offer - WIP
9ba97a0
@soaresa
set error codes for offer functions
7846aad
@soaresa
adds more tests to multi action offer
3c6b191
@soaresa
applies canonical errors to offer functions, and creates more tests
e9892ff
@soaresa
supports submit new offers, and adds more tests
dffd5da
@soaresa
applies new offer flow to the other tests
852e7b4
@soaresa
adds offer flow to new authorities voted
beb8e4b
@soaresa
creates multisign signer to offer authorities triggered by vote, and …
6c4955f 
…drop offer after finalize and after last claim
@soaresa
add test finalize multisign account having a pending claim
e3f0a3e
@soaresa
adds migration to init offer, and never drop the offer
d729c98 
updates tests error codes
@soaresa
adds test for expired offer
38a1bf3
@soaresa
cleans proposed list only when offer is expired
b84ecd1
@soaresa
adds support for epoch expiration per authority
eddd10a
@soaresa
fixes adding to offer authorities voted in different votes before claims
2f38b78
@soaresa
clean up
1750102
@soaresa
set max number of offer addresses to avoid DoS
80f52a5
@soaresa
test default value of epochs to expire
0d5e57d
@soaresa
ensure proposed list is distinct addresses and without owner
ffe0f7c
@soaresa
adds tests for offer migration
28bb4fa
@soaresa
ensures gov proposes cannot have invalid, duplicated and owner address
e760ce2
@soaresa
adds new constraints and tests to multi_action governance
587146d
@soaresa
refactoring
0104e95
@soaresa
fixes indentation
78bd05b
@soaresa
creates module multi_action_migration - WIP
a26f753
@soaresa
converts error codes to decimal notation
7d3ddd8
@soaresa
sets expire epoch to use offer migration
6455c70
@soaresa
converts exist_offer into a view function
621dbbb
@soaresa
comments code not used and not tested
d54965a
soaresa added 28 commits July 19, 2024 09:47
@soaresa
set multi_action propose_offer not a transaction
a5220de
@soaresa
implementing first smoke test to create community wallet with offer/c…
5a8f673 
…laim pattern
@soaresa
community wallet cli test refactoring
61a7366
@soaresa
prints a message after txs completed and update test comments
d4eadfd
@soaresa
adds propose_offer cli and smoke test update_community_wallet_offer
681b9f0
@soaresa
create test vote new signer to cw + migrate cw tests to community_wal…
efc904c 
…let.rs
@soaresa
fix threshold bug to remove admin from cw + add test to vote removal …
a0a0f1e 
…of admin from cw
@soaresa
cargo fmt && cargo clippy
ea0bef2
@soaresa
improves cw tests, fix a threshold bug, duplicated error codes, and e…
d545f13 
…rror codes usage
@soaresa
adds CLI and smoke test for offer migration
7f24ea0
@soaresa
fix threshold check to reduce cw admins
74c843d
@soaresa
adds offer migration test with twin db
9f1e842
@soaresa
applies fmt --all
6fea329
@soaresa
fixes linting errors
9d73337
@soaresa
updates a constant name
66db030
@soaresa
lint fixes
477b9ac
@soaresa
lint fixes for libra framework sdk builder
644eafe
@soaresa
shuffles validators with same bid value
e13b4aa
@soaresa
reduces val set for competition between qualified bidders having 21 o…
9953fec 
…r more compliant
@soaresa
initializes randomness on ol_reconfigure_for_test
a263af4
@soaresa
refactors musical chairs mod and adds more tests
2c2b827
@soaresa
gitignore target folders, and move coverage files
d56cfe8
@soaresa
fixes reward thermostat call order - WIP
f726412 
clean up code
@soaresa
fix budget to collect, and fee calculus
3265bd4 
test subsidy, fees and reward payments
@soaresa
test subsidy and rewards having a non compliant val
a42ca78
@soaresa
test that entry fee sum is burnt on epoch trigger
11647e9
@soaresa
adds tests to reward_thermostat increasing and decreasing rewards
89e9c87 
fixes tests broken by mock changes
@soaresa
extracts pure function from reward_thermostat and adds tests
b5a01fe 
creates view query_reward_adjustment
@soaresa soaresa force-pushed the breaking/pof_tiebreaker branch from dabc7ae to b5a01fe Compare July 19, 2024 12:48
@soaresa soaresa closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soaresa @0o-de-lally