Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add npm deploy and move backend source to /api folder #3422

Merged
merged 10 commits into from
Nov 16, 2023
Merged

feat: add npm deploy and move backend source to /api folder #3422

merged 10 commits into from
Nov 16, 2023

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Nov 14, 2023 •
edited
Loading

Fixes #3418

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6865821291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.569%
Totals Coverage Status
Change from base Build 6865813205: 0.0%
Covered Lines: 3728
Relevant Lines: 18400
💛 - Coveralls

@robertsLando
Copy link
Member Author

robertsLando commented Nov 16, 2023 •
edited
Loading

TODOs:

@robertsLando robertsLando changed the title feat: add npm deploy feat: add npm deploy and move backend source to /api folder Nov 16, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 16, 2023
View reviewed changes
api/config/app.ts
export const port: string | number = process.env.PORT || 8091
export const host: string = process.env.HOST // by default undefined, so it will listen on all interfaces both ipv4 and ipv6
export const sessionSecret: string =
process.env.SESSION_SECRET || 'DEFAULT_SESSION_SECRET_CHANGE_ME'

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "DEFAULT_SESSION_SECRET_CHANGE_ME" is used as [key](1). The hard-coded value "DEFAULT_SESSION_SECRET_CHANGE_ME" is used as [key](2).
@robertsLando
Copy link
Member Author

robertsLando commented Nov 16, 2023 •
edited
Loading

@frenck @jmgiaever FYI after this will be released:

All backend files have been moved to api folder, this includes bin config hass lib and app.ts. In case HA addon or snap package could be broken by this change I inform you.

In future I would like to switch to a monorepo using lerna but that requires much more work and I'm not sure I want it yet...

@robertsLando robertsLando merged commit fe7a2c5 into master Nov 16, 2023
@robertsLando robertsLando deleted the npm-pack branch November 16, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish package to npmjs registry
1 participant
@robertsLando